nix-update: refactor #342397
Merged
nix-update: refactor #342397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonTorres
force-pushed
the
upload-nix-update
branch
from
d3ddecf
to
1c836f5
Compare
AndersonTorres
force-pushed
the
upload-nix-update
branch
from
1c836f5
to
328e756
Compare
dotlambda
reviewed
Sep 17, 2024
- use python3Packages - because splicing - be more explicit - do not use pname as parameter - meta.homepage - checkPhase -> installCheckPhase - no nested with - no platforms.all - because Python is not in all platforms
So that nix-update-script can refer to nix-update itself.
AndersonTorres
force-pushed
the
upload-nix-update
branch
from
328e756
to
ca641eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.