Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nile: 1.1.1 -> 1.1.2 #342414

Merged
merged 2 commits into from
Sep 17, 2024
Merged

nile: 1.1.1 -> 1.1.2 #342414

merged 2 commits into from
Sep 17, 2024

Conversation

aidalgol
Copy link
Contributor

Description of changes

Update package nile to latest upstream release.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aidalgol
nile: use gitUpdater
a32efff 
Upstream tags releases, so we should not be using gitUnstableUpdater
when tracking release tags.
@aidalgol
nile: 1.1.1 -> 1.1.2
97e8804
@aidalgol aidalgol mentioned this pull request Sep 16, 2024
Closed
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Sep 17, 2024
@nbraud
Copy link
Contributor

nbraud commented Sep 17, 2024

Result of nixpkgs-review pr 342414 run on aarch64-darwin 1

2 packages built:
  • nile
  • nile.dist

@nbraud
Copy link
Contributor

nbraud commented Sep 17, 2024

Result of nixpkgs-review pr 342414 run on x86_64-linux 1

4 packages built:
  • heroic
  • heroic-unwrapped
  • nile
  • nile.dist

@nbraud nbraud merged commit 82c5da9 into NixOS:master Sep 17, 2024
28 of 30 checks passed
@aidalgol aidalgol deleted the nile-1.1.2 branch September 18, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidalgol @nbraud