Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ikos: 3.2 -> 3.3 #342417

Merged
merged 2 commits into from
Sep 17, 2024
Merged

ikos: 3.2 -> 3.3 #342417

merged 2 commits into from
Sep 17, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Sep 16, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review September 16, 2024 23:00
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 17, 2024
@nbraud
Copy link
Contributor

nbraud commented Sep 17, 2024

Result of nixpkgs-review pr 342417 run on aarch64-darwin 1

nbraud
nbraud approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, concurrently trying to build it

@nbraud
Copy link
Contributor

nbraud commented Sep 17, 2024

Result of nixpkgs-review pr 342417 run on x86_64-linux 1

1 package built:
  • ikos

@nbraud
Copy link
Contributor

nbraud commented Sep 17, 2024

Tested the program on a toy C++ example, works.

@nbraud nbraud merged commit 63fbe94 into NixOS:master Sep 17, 2024
33 of 35 checks passed
@nbraud
Copy link
Contributor

nbraud commented Sep 17, 2024

Result of nixpkgs-review pr 342417 run on aarch64-darwin 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbsds @nbraud