Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] Revert "zfs: dynamically determine latestCompatibleLinuxPackages" #342495

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Sep 17, 2024

This reverts commit 27b52ad.

Fixes #341867

We could select linux_6_10 now if we wanted but I opted for linux_6_6 instead because this will be removed anyways.

This is technically a breaking change but latestCompatibleLinuxPackages has no expectancy of stability in the first place.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reverts commit 27b52ad.

Fixes NixOS#341867

We could select linux_6_10 now if we wanted but I opted for linux_6_6 instead
because this will be removed anyways.

This is technically a breaking change but latestCompatibleLinuxPackages has no
expectancy of stability in the first place.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 17, 2024
@Atemu Atemu changed the title Revert "zfs: dynamically determine latestCompatibleLinuxPackages" [24.05] Revert "zfs: dynamically determine latestCompatibleLinuxPackages" Sep 17, 2024
@Atemu Atemu requested review from Mic92 and wegank September 17, 2024 11:00
@emilazy

This comment was marked as resolved.

@adamcstephens adamcstephens merged commit 2e78a4c into NixOS:release-24.05 Sep 17, 2024
27 of 28 checks passed
@Atemu Atemu deleted the revert/zfs/dynamically-determine-latestCompatibleLinuxPackages branch September 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants