-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lammps and python312Packages.lammps related fixes #342532
base: master
Are you sure you want to change the base?
Conversation
bbf21d7
to
45576d9
Compare
@@ -0,0 +1,13 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of lamps-mpi
should probably still go into all-packages.nix
(if I read this correctly: https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#readme)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes this warning by PyLammps go away: > WARNING: run thermo data not captured since PYTHON LAMMPS package is not enabled
45576d9
to
d068511
Compare
Found out this was needed when trying to override the python package to use a LAMMPS compiled with GPU support.
Description of changes
Things done
nix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.