Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktor-cli: init at 0.2.0 #342601

Closed
wants to merge 2 commits into from
Closed

ktor-cli: init at 0.2.0 #342601

wants to merge 2 commits into from

Conversation

nartsisss
Copy link
Member

@nartsisss nartsisss commented Sep 17, 2024 •
edited
Loading

Description of changes

New ktor-cli package: tool for creating Ktor projects through the command line interface

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 17, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 17, 2024
Bot-wxt1221
Bot-wxt1221 reviewed Sep 19, 2024
View reviewed changes
pkgs/by-name/kt/ktor-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/kt/ktor-cli/package.nix Outdated Show resolved Hide resolved
Bot-wxt1221
Bot-wxt1221 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 19, 2024
@nartsisss nartsisss mentioned this pull request Sep 20, 2024
Closed
13 tasks
@nartsisss nartsisss closed this Sep 20, 2024
@nartsisss nartsisss deleted the init-ktor branch September 20, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nartsisss @Bot-wxt1221 @wegank @NixOSInfra