yarnInstallHook: fix temporary directory location

[lelgenio]

Currently the directory is being created in $src/yarnInstallHook.XXXXXX

Giving the directory a readable name is not particularly useful.

Fixes: #342151

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[lelgenio]

Result of nixpkgs-review pr 342608 run on x86_64-linux 1

5 packages built:

• blade-formatter
• codefresh
• element-call
• postlight-parser
• yarnInstallHook

[TomaSajt]

Thanks, LGTM

[doronbehar]

Thanks for catching that. I wonder why we used a temporary directory at all, but I don't mind that much now.

[doronbehar]

Verified that the patch indeed makes the node_modules dir not get polluted by the temporary directory.