Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/authelia: complete level enum #342619

Merged
merged 1 commit into from
Sep 19, 2024
Merged

nixos/authelia: complete level enum #342619

merged 1 commit into from
Sep 19, 2024

Conversation

hatch01
Copy link
Contributor

@hatch01 hatch01 commented Sep 17, 2024

Description of changes

Update the level enum according to the official authelia documentation

Things done

Level enum updated

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 17, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 17, 2024
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff seems good to me

@h7x4
Copy link
Member

h7x4 commented Sep 17, 2024

Maybe you could amend the commit message prefix to nixos/authelia: to specify that this regards the module and not the package?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 17, 2024
@hatch01 hatch01 changed the title authelia: complete level enum nixos/authelia: complete level enum Sep 18, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 18, 2024
@h7x4 h7x4 merged commit dcf1beb into NixOS:master Sep 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants