Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mir: 2.17.2 -> 2.18.2 #342624

Merged
merged 5 commits into from
Oct 2, 2024
Merged

mir: 2.17.2 -> 2.18.2 #342624

merged 5 commits into from
Oct 2, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Sep 17, 2024

Description of changes

  • nixfmt the common file
  • update the unpinned mir to 2.18.2
  • add Miriway and Miracle WM's VM tests as tests for Mir, so I don't need to manually invoke OfBorg for them all the time

Draft because it's brand new, and miracle-wm is not compatible with it yet: miracle-wm-org/miracle-wm#243
Addressed by new release, included in PR: https://github.com/miracle-wm-org/miracle-wm/releases/tag/v0.3.6

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from onny September 17, 2024 21:28
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 17, 2024
@OPNA2608 OPNA2608 marked this pull request as ready for review September 27, 2024 20:11
@OPNA2608 OPNA2608 changed the title mir: 2.17.2 -> 2.18 mir: 2.17.2 -> 2.18.2 Sep 28, 2024
@OPNA2608 OPNA2608 merged commit b7d495d into NixOS:master Oct 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant