rustc: generate config.toml
from attrset
#342627
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR changes the way
rustc
is configured during bootstrapping. At the moment, the configuration is done by passingconfigureFlags
to theconfigure
, a Python script that adapts an example TOML file. This script is considered by upstream as a shim, and although it can pretty much set any arbitrary key-value pair using the--set
flags, this is error-prone as the script doesn't use a proper TOML parser. For instance, we regularly encountered errors during writing (due toconfigure
) or reading (bootstrap
) with a target architecture with a dot in it (thumbv8m.main-none-eabi
).According to upstream, the true configuration interface for rustc is the
config.toml
. As such, in this PR I propose having a configuration attrset that is serialized into aconfig.toml
file.At first sight, this change can be considered superfluous. However I think having a more direct interface to the
config.toml
file can be a better tool to avoid errors and ultimately to increase reproducibility, as the generated file is the true configuration source.Things done
Right now I tested this with a cross-compilation for a nitrokey-3 firmware.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.