Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.orbax-checkpoint: 0.6.3 -> 0.6.4 #342636

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Sep 17, 2024

Description of changes

Changelog: https://github.com/google/orbax/blob/0.6.4/CHANGELOG.md

cc @fabaff

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff
Copy link
Member

fabaff commented Sep 17, 2024

Result of nixpkgs-review pr 342636 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist
  • python311Packages.treex
  • python311Packages.treex.dist
16 packages built:
  • python311Packages.dalle-mini
  • python311Packages.dalle-mini.dist
  • python311Packages.dm-haiku
  • python311Packages.dm-haiku.dist
  • python311Packages.evosax
  • python311Packages.evosax.dist
  • python311Packages.flax
  • python311Packages.flax.dist
  • python311Packages.flowmc
  • python311Packages.flowmc.dist
  • python311Packages.orbax-checkpoint
  • python311Packages.orbax-checkpoint.dist
  • python311Packages.vqgan-jax
  • python311Packages.vqgan-jax.dist
  • python312Packages.orbax-checkpoint
  • python312Packages.orbax-checkpoint.dist

1 similar comment
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 342636 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist
  • python311Packages.treex
  • python311Packages.treex.dist
16 packages built:
  • python311Packages.dalle-mini
  • python311Packages.dalle-mini.dist
  • python311Packages.dm-haiku
  • python311Packages.dm-haiku.dist
  • python311Packages.evosax
  • python311Packages.evosax.dist
  • python311Packages.flax
  • python311Packages.flax.dist
  • python311Packages.flowmc
  • python311Packages.flowmc.dist
  • python311Packages.orbax-checkpoint
  • python311Packages.orbax-checkpoint.dist
  • python311Packages.vqgan-jax
  • python311Packages.vqgan-jax.dist
  • python312Packages.orbax-checkpoint
  • python312Packages.orbax-checkpoint.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 342636 run on x86_64-darwin 1

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 342636 run on aarch64-linux 1

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 342636 run on aarch64-darwin 1

20 packages marked as broken and skipped:
  • python311Packages.dalle-mini
  • python311Packages.dalle-mini.dist
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.dm-haiku
  • python311Packages.dm-haiku.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.evosax
  • python311Packages.evosax.dist
  • python311Packages.flax
  • python311Packages.flax.dist
  • python311Packages.flowmc
  • python311Packages.flowmc.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python311Packages.vqgan-jax
  • python311Packages.vqgan-jax.dist
4 packages built:
  • python311Packages.orbax-checkpoint
  • python311Packages.orbax-checkpoint.dist
  • python312Packages.orbax-checkpoint
  • python312Packages.orbax-checkpoint.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@pbsds pbsds merged commit f0a876c into NixOS:master Sep 17, 2024
27 of 29 checks passed
@GaetanLepage GaetanLepage deleted the orbax branch September 18, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants