Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knossosnet: 1.2.0 -> 1.2.3 #342647

Merged
merged 1 commit into from
Sep 30, 2024
Merged

knossosnet: 1.2.0 -> 1.2.3 #342647

merged 1 commit into from
Sep 30, 2024

Conversation

cdombroski
Copy link
Contributor

@cdombroski cdombroski commented Sep 17, 2024

Manual update due to changes needed in deps.nix

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Manual update due to changes needed in deps.nix
@melvyn2
Copy link
Contributor

melvyn2 commented Sep 30, 2024

Result of nixpkgs-review pr 342647 run on x86_64-linux 1

1 package built:
  • knossosnet

@melvyn2 melvyn2 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 30, 2024
@h7x4 h7x4 merged commit 303c750 into NixOS:master Sep 30, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants