Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-serve: pin nix to nixVersions.nix_2_18 (previous stable) due to breaking changes #342716

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

fabianhjr
Copy link
Member

Description of changes

Alternative for #342714

Fixes broken nixosTests.nix-serve after

#335342

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabianhjr
Copy link
Member Author

@ofborg test nix-serve

@Aleksanaa Aleksanaa marked this pull request as ready for review September 18, 2024 05:56
@Aleksanaa Aleksanaa merged commit 3385895 into NixOS:master Sep 18, 2024
30 of 34 checks passed
@fabianhjr fabianhjr deleted the nix-serve-pin-nix branch September 18, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants