draupnir: init at 2.0.0-beta.6 #342893
Draft
draupnir: init at 2.0.0-beta.6 #342893
+7,424
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterqt
commented
Sep 18, 2024
|
|
||
| # TODO: move to preNpmRebuild | ||
| preBuild = '' | ||
| rm -r node_modules/better-sqlite3/{build,deps/common.gypi,deps/sqlite3.gyp,deps/sqlite3} |
There was a problem hiding this comment.
# Remove things we know we don't need that just increase closure size.
There was a problem hiding this comment.
Isn't that still needed for sqlite?
| nativeBuildInputs = [ pkg-config ]; | ||
| buildInputs = [ sqlite ]; | ||
|
|
||
| # TODO: move to preNpmRebuild |
There was a problem hiding this comment.
Unsure yet if I'd like to do this in this PR (would decrease build time by a bit), but we'll see after it gets tested.
| uses across an entire homeserver. | ||
| ''; | ||
| license = licenses.afl3; | ||
| maintainers = with maintainers; [ winter ]; |
There was a problem hiding this comment.
@TheArcaneBrony Do let me know if you'd like to be added as a maintainer.
There was a problem hiding this comment.
IIRC vendored package-lock.json was why the Draupnir package was rewritten from scratch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This supersedes the package portion of #274052, as discussed in Matrix, by packaging Draupnir in a way that is:
mkYarnPackage, thus requires slightly less work, like no manual wrapping being required).However, this has the caveat that it requires a vendored
package-lock.json. Sorry!This needs testers! I'm not sure if I can just drop in the Mjölnir module and test it or not, though I guess someone can just test it with the module from #274052.
Thanks to @TheArcaneBrony for creating the original PRs and the module, which will continue to be worked on in that PR.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.