Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/services.tarsnap: fix escapeSystemdPath #342911

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

wahjava
Copy link
Contributor

@wahjava wahjava commented Sep 19, 2024

Description of changes

Fix for following error:

   error: attribute 'lib' missing

   at /nix/store/cjz8w4dgc3rd2n3dqv5c208vygndjyba-source/nixos/modules/services/backup/tarsnap.nix:90:49:

       89|                 type = lib.types.nullOr lib.types.path;
       90|                 default = "/var/cache/tarsnap/${utils.lib.escapeSystemdPath config.keyfile}";
         |                                                 ^
       91|                 defaultText = lib.literalExpression ''

introduced by e53c595 (#335631)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 19, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 19, 2024
@h7x4 h7x4 merged commit a79863f into NixOS:master Sep 19, 2024
25 checks passed
@wahjava wahjava deleted the fix/tarsnap-module branch September 19, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants