Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pritunl-client: 1.3.3785.81 -> 1.3.4026.10 #343015

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrevmatos
Copy link
Member

@andrevmatos andrevmatos commented Sep 19, 2024

Description of changes

https://github.com/pritunl/pritunl-client-electron/releases/tag/1.3.4024.40
https://github.com/pritunl/pritunl-client-electron/releases/tag/1.3.4026.10

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@andrevmatos andrevmatos changed the title pkgs/pritunl-client: v1.3.3785.81 -> 1.3.4024.40 pkgs/pritunl-client: 1.3.3785.81 -> 1.3.4024.40 Sep 19, 2024
@andrevmatos
Copy link
Member Author

Result of nixpkgs-review pr 343015 --checkout commit run on x86_64-linux 1

1 package built:
  • pritunl-client

@NickCao
Copy link
Member

NickCao commented Sep 20, 2024

Please follow the commit message guidelines, that would be pritunl-client: 1.3.3785.81 -> 1.3.4024.40

Side note: this is more than aesthetic, it allows ofborg the bot to automatically build the changed package (well not this particular one since it's unfree, but you get the idea).

@andrevmatos andrevmatos changed the title pkgs/pritunl-client: 1.3.3785.81 -> 1.3.4024.40 pritunl-client: 1.3.3785.81 -> 1.3.4024.40 Sep 20, 2024
@andrevmatos andrevmatos changed the title pritunl-client: 1.3.3785.81 -> 1.3.4024.40 pritunl-client: 1.3.3785.81 -> 1.3.4026.10 Sep 20, 2024
@ofborg ofborg bot requested a review from minizilla September 20, 2024 09:34
@NickCao
Copy link
Member

NickCao commented Sep 20, 2024

Ah please squash the commit and we are good to go.

@andrevmatos
Copy link
Member Author

@NickCao sorry, I thought the squash could/would happen when squash-merging the PR;
Squashed and rebased manually. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants