Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-plugins: pinned to nix 2.18 #343043

Closed
wants to merge 1 commit into from
Closed

nix-plugins: pinned to nix 2.18 #343043

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 19, 2024

the current version is only compatible with nix 2.18. To not have to have to jump back and forth with every nix update this is pinned for now.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

the current version is only compatible with nix 2.18.
To not have to have to jump back and forth with every nix update this is
pinned for now.
@Mic92
Copy link
Member Author

Mic92 commented Sep 19, 2024

Context: #343032

@shlevy
Copy link
Member

shlevy commented Sep 19, 2024

Hmm to be clear this is not the current version of nix-plugins, it’s an old version. Once we have 2.24 back in we can bump nix-plugins without the pin, and in general I’d like to ensure nix-plugins is always built against whatever nixpkgs thinks of as nix. Is there a reason we can’t just keep this as-is? We already have the bump commit to rerevert once 2.24 is ready.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 19, 2024
@Mic92
Copy link
Member Author

Mic92 commented Sep 19, 2024

Hmm to be clear this is not the current version of nix-plugins, it’s an old version. Once we have 2.24 back in we can bump nix-plugins without the pin, and in general I’d like to ensure nix-plugins is always built against whatever nixpkgs thinks of as nix. Is there a reason we can’t just keep this as-is? We already have the bump commit to rerevert once 2.24 is ready.

I would like to keep the next pull request that bumps nix small and not have to also bump the whole ecosystem around nix as well. If you want to be updated in lock step with Nix, please make sure you are frequently tracking nixVersions.git and nixVersions.latest and not wait for the nix attribute to bump to fix your plugins. It's too much work otherwise onto the Nix team to keep things building.

@Mic92 Mic92 closed this Sep 23, 2024
@Mic92 Mic92 deleted the nix-plugins branch September 23, 2024 11:01
@shlevy
Copy link
Member

shlevy commented Sep 25, 2024

That's a fair request, I'll start tracking against .git and ensure I'm fixing breakages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants