nixos/tools: start cleanup #343075
Merged
nixos/tools: start cleanup #343075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has no other consumers anyway. Also saves some work.
github-actions
bot
added
6.topic: nixos
|
The main objective of the mentioned PR, was to avoid rebuilding system-path on every commit. Making the packages overridable was kind of a side mission. I'm also very much in favour of this change by itself though, it's annoying when packages are not easily overridable. |
|
That's going to be in the next commits that I haven't finished yet :) |
r-vdp
reviewed
Sep 19, 2024
K900
force-pushed
the
nixos-tools-cleanup
branch
2 times, most recently
from
3ac493c
to
558158a
Compare
|
@NixOS/nixpkgs-vet that's an interesting failure mode |
ofborg
bot
added
8.has: package (new)
|
@ofborg test nixos-rebuild installer |
K900
force-pushed
the
nixos-tools-cleanup
branch
from
558158a
to
51b4762
Compare
|
@ofborg test nixos-rebuild installer |
|
OK, looking at nixos-generate-config, that'll be a huge pain to untangle and I'm considering just rewriting it entirely, so I'm going to send this as is, as it's already an improvement. |
13 tasks
|
Nice work on this @K900. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is kind of a spiritual successor to #238557, achieved by just moving more things out of the NixOS module system and into normal packages. This iteration starts with
nixos-build-vms,nixos-enterandnixos-install, all three of which don't depend on any config state except Nix itself.nixos-generate-configcan probably also move out, but will require some refactoring to do so, and I'm not sure aboutnixos-version, but this is a start.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.