Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.braceexpand: modernize, adopt #343142

Merged
merged 1 commit into from
Sep 20, 2024
Merged

python312Packages.braceexpand: modernize, adopt #343142

merged 1 commit into from
Sep 20, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Sep 19, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review September 19, 2024 23:17
@ofborg ofborg bot requested a review from newAM September 20, 2024 01:47
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 20, 2024
@newAM
Copy link
Member

newAM commented Sep 20, 2024

Result of nixpkgs-review pr 343142 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.jishaku
  • python311Packages.jishaku.dist
  • python312Packages.jishaku
  • python312Packages.jishaku.dist
25 packages built:
  • emborg (python312Packages.emborg)
  • emborg.dist (python312Packages.emborg.dist)
  • python311Packages.braceexpand
  • python311Packages.braceexpand.dist
  • python311Packages.emborg
  • python311Packages.emborg.dist
  • python311Packages.ffcv
  • python311Packages.ffcv.dist
  • python311Packages.open-clip-torch
  • python311Packages.open-clip-torch.dist
  • python311Packages.shlib
  • python311Packages.shlib.dist
  • python311Packages.webdataset
  • python311Packages.webdataset.dist
  • python312Packages.braceexpand
  • python312Packages.braceexpand.dist
  • python312Packages.open-clip-torch
  • python312Packages.open-clip-torch.dist
  • python312Packages.shlib
  • python312Packages.shlib.dist
  • python312Packages.webdataset
  • python312Packages.webdataset.dist
  • rclip
  • rclip.dist
  • rrsync

newAM
newAM approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@newAM newAM added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 20, 2024
@pbsds pbsds merged commit fd32be7 into NixOS:master Sep 20, 2024
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newAM newAM newAM approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbsds @newAM