Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages: unify version for all platforms but Darwin #343245

Merged
merged 1 commit into from
Sep 22, 2024
Merged

llvmPackages: unify version for all platforms but Darwin #343245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15422,18 +15422,12 @@ with pkgs;
libllvm = llvmPackages.libllvm;
llvm-manpages = llvmPackages.llvm-manpages;

# Please remove all this logic when bumping to LLVM 19 and make this
# a simple alias.
llvmPackages = let
# This returns the minimum supported version for the platform. The
# assumption is that or any later version is good.
choose = platform:
/**/ if platform.isDarwin then 16
else if platform.isFreeBSD then 18
else if platform.isOpenBSD then 18
else if platform.isAndroid then 12
else if platform.isLinux then 18
else if platform.isWasm then 16
# For unknown systems, assume the latest version is required.
else 18;
choose = platform: if platform.isDarwin then 16 else 18;
# We take the "max of the mins". Why? Since those are lower bounds of the
# supported version set, this is like intersecting those sets and then
# taking the min bound of that.
Expand Down