add support for building fully dm-verity protected images with systemd-repart #343252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nikstur <[email protected]> Co-authored-by: WilliButz <[email protected]>
WilliButz
requested review from
RaitoBezarius,
ElvishJerricco,
jmbaur,
msanft and
nikstur
|
@ofborg test appliance-repart-image-verity-store |
github-actions
bot
added
6.topic: nixos
WilliButz
force-pushed
the
repart-image/verity-store
branch
from
29f5911
to
9c414e9
Compare
msanft
reviewed
Sep 20, 2024
|
hmm, was the ofborg test cancelled because of the force-push with the formatting change? 👀 @ofborg test appliance-repart-image-verity-store |
WilliButz
commented
Sep 20, 2024
msanft
reviewed
Sep 20, 2024
msanft
reviewed
Sep 20, 2024
msanft
reviewed
Sep 20, 2024
msanft
reviewed
Sep 20, 2024
There was a problem hiding this comment.
✅ NixOS test works
✅ My own read-only-root use-case works
✅ Personal non-NixOS-test usage test of the usr-scaffolded integrity-protected Nix store works
Great PR! Thank you so much for picking this up. Will approve once the remaining nits of mine are addressed.
ofborg
bot
added
10.rebuild-darwin: 0
WilliButz
force-pushed
the
repart-image/verity-store
branch
2 times, most recently
from
ea2b97b
to
6c03e64
Compare
msanft
approved these changes
Sep 20, 2024
RaitoBezarius
previously requested changes
Sep 20, 2024
There was a problem hiding this comment.
There's an infrec architectural loop.
If you are using image repart to create an ESP with a UKI reference, the intermediate image will reference that UKI reference which is overriden to point to the new UKI with the intermediate image reference.
Causing an infinite recursion. I am not sure what is the easiest here.
This module provides some abstraction for a multi-stage build to create a dm-verity protected NixOS repart image. The opinionated approach realized by this module is to first create an immutable, verity-protected nix store partition, then embed the root hash of the corresponding verity hash partition in a UKI, that is then injected into the ESP of the resulting image. The UKI can then precisely identify the corresponding data from which the entire system is bootstrapped. The module comes with a script that checks the UKI used in the final image corresponds to the intermediate image created in the first step. This is necessary to notice incompatible substitutions of non-reproducible store paths, for example when working with distributed builds, or when offline-signing the UKI.
This test should illustrate how to build a verity-protected NixOS image with systemd-repart, using the opinionated image.repart.verityStore module.
WilliButz
commented
Sep 20, 2024
WilliButz
force-pushed
the
repart-image/verity-store
branch
from
6c03e64
to
56d038e
Compare
RaitoBezarius
approved these changes
Sep 20, 2024
arianvp
approved these changes
Sep 20, 2024
13 tasks
arianvp
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Please see the commit messages for more details.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)