Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: update to latest #343261

Merged
merged 1 commit into from
Sep 21, 2024
Merged

nodePackages: update to latest #343261

merged 1 commit into from
Sep 21, 2024

Conversation

pinpox
Copy link
Member

@pinpox pinpox commented Sep 20, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from Luflosi September 20, 2024 14:06
@natsukium
Copy link
Member

natsukium commented Sep 21, 2024 •
edited
Loading

Result of nixpkgs-review pr 343261 at 5815729 run on x86_64-linux 1

2 packages failed to build:
  • discourse
  • discourseAllPlugins
28 packages built successfully:
  • akkoma-frontends.akkoma-fe
  • commitlint
  • create-cycle-app
  • emanote (haskellPackages.emanote)
  • emanote.data (haskellPackages.emanote.data)
  • emanote.doc (haskellPackages.emanote.doc)
  • emojione
  • fast-cli
  • gancio
  • haskellPackages.tailwind
  • haskellPackages.tailwind.doc
  • image_optim
  • joplin
  • lighthouse
  • lunarvim
  • postcss-cli
  • pscid
  • shout
  • theLoungePlugins.plugins.closepms
  • theLoungePlugins.plugins.giphy
  • theLoungePlugins.themes.flat-blue
  • theLoungePlugins.themes.flat-dark
  • uppy-companion
  • vimPlugins.coc-explorer
  • vimPlugins.coc-metals
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-tsserver
  • vscode-extensions.rust-lang.rust-analyzer

Result of nixpkgs-review pr 343261 at 5815729 run on aarch64-darwin 1

2 packages marked as broken and skipped:
  • joplin
  • lighthouse
22 packages built successfully:
  • commitlint
  • create-cycle-app
  • emanote (haskellPackages.emanote)
  • emanote.data (haskellPackages.emanote.data)
  • emanote.doc (haskellPackages.emanote.doc)
  • haskellPackages.tailwind
  • haskellPackages.tailwind.doc
  • image_optim
  • lunarvim
  • postcss-cli
  • pscid
  • shout
  • theLoungePlugins.plugins.closepms
  • theLoungePlugins.plugins.giphy
  • theLoungePlugins.themes.flat-blue
  • theLoungePlugins.themes.flat-dark
  • uppy-companion
  • vimPlugins.coc-explorer
  • vimPlugins.coc-metals
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-tsserver
  • vscode-extensions.rust-lang.rust-analyzer

natsukium
natsukium approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium natsukium merged commit ab45bce into NixOS:master Sep 21, 2024
27 checks passed
@pinpox pinpox deleted the update-nodepkgs branch September 26, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@Luflosi Luflosi Luflosi approved these changes

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinpox @natsukium @Luflosi