Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.skyfield: 1.45 -> 1.49, fixed tests #343265

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

yl3dy
Copy link
Contributor

@yl3dy yl3dy commented Sep 20, 2024

Description of changes

Fixed tests by updating assay to the latest version (which now supports Python 3.12), updated skyfield to the latest 1.49.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yl3dy
Copy link
Contributor Author

yl3dy commented Sep 20, 2024

Result of nixpkgs-review pr 343265 run on x86_64-linux 1

8 packages built:
  • python311Packages.assay
  • python311Packages.assay.dist
  • python311Packages.skyfield
  • python311Packages.skyfield.dist
  • python312Packages.assay
  • python312Packages.assay.dist
  • python312Packages.skyfield
  • python312Packages.skyfield.dist

@pbsbot
Copy link

pbsbot commented Sep 24, 2024

Result of nixpkgs-review pr 343265 run on x86_64-linux 1

8 packages built:
  • python311Packages.assay
  • python311Packages.assay.dist
  • python311Packages.skyfield
  • python311Packages.skyfield.dist
  • python312Packages.assay
  • python312Packages.assay.dist
  • python312Packages.skyfield
  • python312Packages.skyfield.dist

@pbsds
Copy link
Member

pbsds commented Sep 24, 2024

installCheckPhase seems to hang on darwin

@pbsds
Copy link
Member

pbsds commented Sep 24, 2024

@ofborg build python312Packages.skyfield

@pbsds
Copy link
Member

pbsds commented Sep 24, 2024

works on ofborg darwin :shipit:

@pbsds pbsds merged commit 24959f9 into NixOS:master Sep 24, 2024
25 of 26 checks passed
@yl3dy yl3dy deleted the skyfield_1_49 branch September 26, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants