ocamlPackages.elpi: use release tarball #343266
Conversation
vbgl
added
8.has: clean-up
6.topic: ocaml
6.topic: coq
| }: | ||
|
|
||
| let p5 = camlp5; in | ||
| let camlp5 = p5.override { legacy = true; }; in | ||
|
|
||
| let fetched = coqPackages.metaFetch ({ |
There was a problem hiding this comment.
@vbgl removing this will break the ability to conveniently overlay ocamlPackages.elpi in various CIs to anything else than released versions, which might be pretty unconvenient. Although I'm not sure how often we use that feature.
Cc @CohenCyril @gares ?
There was a problem hiding this comment.
Right. So my question is: can we use metaFetch to download the released artifacts when available?
There was a problem hiding this comment.
I use that feature via the coq nix toolbox.
But I also need elpi to have a version number (for conditional compilation).
I hope both requirements are not in conflict.
There was a problem hiding this comment.
can we use
metaFetchto download the released artifacts when available?
I don't know, but if not, maybe an option can be added?
There was a problem hiding this comment.
Right. So my question is: can we use
metaFetchto download the released artifacts when available?
Sure, feel free to amend the default-fetcher here:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/coq/meta-fetch/default.nix
You can add an extra "artifact" argument (false by default?) to change the url in the github case here:
nixpkgs/pkgs/build-support/coq/meta-fetch/default.nix
Lines 38 to 39 in a11ec09
There was a problem hiding this comment.
I use fetchurl when you probably use fetchzip?
There was a problem hiding this comment.
Ah ... sure, but I thought the uncompressed archives were compared... why is the result different?
There was a problem hiding this comment.
fetchurl does not decompress: it computes the hash of the downloaded file.
There was a problem hiding this comment.
Thanks. Cherry-picked to this branch.
wegank
added
the
12.approvals: 1
Update after NixOS/nixpkgs#343266
Description of changes
Released tarballs include correct version information.
Tests: coq-community/coq-nix-toolbox#266
cc @gares @proux01
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.