Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zotero: 7.0.3 -> 7.0.5 and add darwin #343384

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions pkgs/applications/office/zotero/darwin.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
stdenv,
fetchurl,
undmg,
pname,
version,
}:

stdenv.mkDerivation {
inherit pname version;
src = fetchurl {
url = "https://download.zotero.org/client/release/${version}/Zotero-${version}.dmg";
sha256 = "sha256-5AhOUCCL1/JUEXuPC9lkjNAHRPjiCqOV9nPb7eU+YdI=";
};

dontBuild = true;

nativeBuildInputs = [ undmg ];

sourceRoot = ".";

installPhase = ''
runHook preInstall

mkdir -p $out/Applications
cp -r *.app $out/Applications

runHook postInstall
'';
}
115 changes: 9 additions & 106 deletions pkgs/applications/office/zotero/default.nix
Original file line number Diff line number Diff line change
@@ -1,116 +1,19 @@
{ lib
, stdenv
, fetchurl
, wrapGAppsHook3
, makeDesktopItem
, alsa-lib
, atk
, cairo
, dbus-glib
, gdk-pixbuf
, glib
, gtk3
, libGL
, libva
, xorg
, mesa
, pango
, pciutils
}:
{ stdenv
, callPackage
, lib}:

stdenv.mkDerivation rec {
let
pname = "zotero";
version = "7.0.3";

src = fetchurl {
url = "https://download.zotero.org/client/release/${version}/Zotero-${version}_linux-x86_64.tar.bz2";
hash = "sha256-W5/j5ohrx/X0qlOiWWtB/FEF9aZCnbbAA3pcL8R6yy0=";
};

dontPatchELF = true;
nativeBuildInputs = [ wrapGAppsHook3 ];

libPath = lib.makeLibraryPath [
alsa-lib
atk
cairo
dbus-glib
gdk-pixbuf
glib
gtk3
libGL
libva
xorg.libX11
xorg.libXcomposite
xorg.libXcursor
xorg.libXdamage
xorg.libXext
xorg.libXfixes
xorg.libXi
xorg.libXrandr
xorg.libXtst
xorg.libxcb
mesa
pango
pciutils
] + ":" + lib.makeSearchPathOutput "lib" "lib64" [ stdenv.cc.cc ];

desktopItem = makeDesktopItem {
name = "zotero";
exec = "zotero -url %U";
icon = "zotero";
comment = meta.description;
desktopName = "Zotero";
genericName = "Reference Management";
categories = [ "Office" "Database" ];
startupNotify = true;
mimeTypes = [ "x-scheme-handler/zotero" "text/plain" ];
};

installPhase = ''
runHook preInstall

# Copy package contents to the output directory
mkdir -p "$prefix/usr/lib/zotero-bin-${version}"
cp -r * "$prefix/usr/lib/zotero-bin-${version}"
mkdir -p "$out/bin"
ln -s "$prefix/usr/lib/zotero-bin-${version}/zotero" "$out/bin/"

# Install desktop file and icons
mkdir -p $out/share/applications
cp ${desktopItem}/share/applications/* $out/share/applications/
for size in 32 64 128; do
install -Dm444 icons/icon''${size}.png \
$out/share/icons/hicolor/''${size}x''${size}/apps/zotero.png
done
install -Dm444 icons/symbolic.svg \
$out/share/icons/hicolor/symbolic/apps/zotero-symbolic.svg

runHook postInstall
'';

postFixup = ''
for executable in \
zotero-bin plugin-container updater vaapitest \
minidump-analyzer glxtest
do
if [ -e "$out/usr/lib/zotero-bin-${version}/$executable" ]; then
patchelf --interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \
"$out/usr/lib/zotero-bin-${version}/$executable"
fi
done
find . -executable -type f -exec \
patchelf --set-rpath "$libPath" \
"$out/usr/lib/zotero-bin-${version}/{}" \;
'';

version = "7.0.5";
meta = with lib; {
homepage = "https://www.zotero.org";
description = "Collect, organize, cite, and share your research sources";
mainProgram = "zotero";
sourceProvenance = with sourceTypes; [ binaryNativeCode ];
license = licenses.agpl3Only;
platforms = [ "x86_64-linux" ];
platforms = [ "x86_64-linux" "aarch64-darwin" ];
maintainers = with maintainers; [ atila justanotherariel ];
};
}
in
if stdenv.isDarwin then callPackage ./darwin.nix { inherit pname version; }
else callPackage ./linux.nix { inherit pname version meta; }
Comment on lines +18 to +19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the meta be exported for/from both derivations?

118 changes: 118 additions & 0 deletions pkgs/applications/office/zotero/linux.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
{
lib,
stdenv,
fetchurl,
wrapGAppsHook3,
makeDesktopItem,
alsa-lib,
atk,
cairo,
dbus-glib,
gdk-pixbuf,
glib,
gtk3,
libGL,
libva,
xorg,
mesa,
pango,
pciutils,
pname,
version,
meta,
}:

stdenv.mkDerivation rec {
inherit pname version;
src = fetchurl {
url = "https://download.zotero.org/client/release/${version}/Zotero-${version}_linux-x86_64.tar.bz2";
hash = "sha256-Ljn2IUMXGhlv/RYpRyzxpdETxQOHWdw70KwPjrcmIT0=";
};

dontPatchELF = true;
nativeBuildInputs = [ wrapGAppsHook3 ];

libPath =
lib.makeLibraryPath [
alsa-lib
atk
cairo
dbus-glib
gdk-pixbuf
glib
gtk3
libGL
libva
xorg.libX11
xorg.libXcomposite
xorg.libXcursor
xorg.libXdamage
xorg.libXext
xorg.libXfixes
xorg.libXi
xorg.libXrandr
xorg.libXtst
xorg.libxcb
mesa
pango
pciutils
]
+ ":"
+ lib.makeSearchPathOutput "lib" "lib64" [ stdenv.cc.cc ];

desktopItem = makeDesktopItem {
name = "zotero";
exec = "zotero -url %U";
icon = "zotero";
comment = meta.description;
desktopName = "Zotero";
genericName = "Reference Management";
categories = [
"Office"
"Database"
];
startupNotify = true;
mimeTypes = [
"x-scheme-handler/zotero"
"text/plain"
];
};

installPhase = ''
runHook preInstall

# Copy package contents to the output directory
mkdir -p "$prefix/usr/lib/zotero-bin-${version}"
cp -r * "$prefix/usr/lib/zotero-bin-${version}"
mkdir -p "$out/bin"
ln -s "$prefix/usr/lib/zotero-bin-${version}/zotero" "$out/bin/"

# Install desktop file and icons
mkdir -p $out/share/applications
cp ${desktopItem}/share/applications/* $out/share/applications/
for size in 32 64 128; do
install -Dm444 icons/icon''${size}.png \
$out/share/icons/hicolor/''${size}x''${size}/apps/zotero.png
done
install -Dm444 icons/symbolic.svg \
$out/share/icons/hicolor/symbolic/apps/zotero-symbolic.svg

runHook postInstall
'';

postFixup = ''
for executable in \
zotero-bin plugin-container updater vaapitest \
minidump-analyzer glxtest
do
if [ -e "$out/usr/lib/zotero-bin-${version}/$executable" ]; then
patchelf --interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \
"$out/usr/lib/zotero-bin-${version}/$executable"
fi
done
find . -executable -type f -exec \
patchelf --set-rpath "$libPath" \
"$out/usr/lib/zotero-bin-${version}/{}" \;
'';

}