Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmstudio: 0.3.3 -> 0.3.4 #347599

Merged
merged 1 commit into from
Oct 13, 2024
Merged

lmstudio: 0.3.3 -> 0.3.4 #347599

merged 1 commit into from
Oct 13, 2024

Conversation

crertel
Copy link
Contributor

@crertel crertel commented Oct 9, 2024

Changes

Full Changelog

Summary

What’s new in 0.3.4:

New

  • MLX support
  • MLX KV caching
  • Mission Control: Cmd+Shift+M to search for models, Cmd+Shift+R to manage LM Runtimes
  • Set Structured Output (JSON Schema) from the UI

Bug Fixes

  • Fix for Black Screen after prolonged use (reference: lmstudio-bug-tracker#98)
  • Fix for no port other than 1234 working for the local server (reference: lms#80)
  • Fix for embedding API not working from Obsidian (reference: tracker#142)
  • Fix for RAG sometimes failing during document processing

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from cig0 and eeedean October 10, 2024 01:05
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 10, 2024
@eeedean
Copy link
Contributor

eeedean commented Oct 10, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 347599


aarch64-darwin

❌ 1 package failed to build:
  • lmstudio

x86_64-linux

✅ 1 package built:
  • lmstudio

Did they change the URL for aarch64-darwin?
it seems to be now:

https://releases.lmstudio.ai/darwin/arm64/0.3.4/3/LM-Studio-0.3.4-arm64.dmg

instead of

https://releases.lmstudio.ai/darwin/arm64/0.3.4/LM-Studio-0.3.4-arm64.dmg

They finally added the build revision into the URL for aarch64-darwin, too. Did you test it beforehand? I suspect, it did not ever work with the current URL in the PR.

@@ -10,7 +10,7 @@ stdenv.mkDerivation {

src = fetchurl {
url = "https://releases.lmstudio.ai/darwin/arm64/${version}/LM-Studio-${version}-arm64.dmg";
Copy link
Contributor

@eeedean eeedean Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • url needs change including build revision:

https://releases.lmstudio.ai/darwin/arm64/${version}/3/LM-Studio-${version}-arm64.dmg

maybe, we even want to put the build revision into its own variable, as it is present in both URLs now?
https://releases.lmstudio.ai/darwin/arm64/${version}/${build-revision}/LM-Studio-${version}-arm64.dmg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps--but the thing is, they keep changing around the URLs on us (at least for the Linux folks--Mac seems stabler). I'm kinda wondering if we should go the other way and just hardcode the URL every time until they get their act together.

@crertel
Copy link
Contributor Author

crertel commented Oct 11, 2024

@eeedean thanks for catching that bad URL, must've fat-fingered it. Not on Mac so my testing there isn't super thorough.

@ofborg ofborg bot requested a review from eeedean October 11, 2024 10:12
Copy link
Contributor

@eeedean eeedean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 347599


aarch64-darwin

✅ 1 package built:
  • lmstudio

x86_64-linux

✅ 1 package built:
  • lmstudio
  • I would appreciate a squash of the commits, please. Then it's perfect imo. 🐱

Edit: Also sorry for taking so long to get back to you ☹️

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 13, 2024
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 13, 2024
@crertel
Copy link
Contributor Author

crertel commented Oct 13, 2024

@eeedean done!

@eeedean
Copy link
Contributor

eeedean commented Oct 13, 2024

In case, you don’t know this friend, yet: https://github.com/nixos/nixpkgs-merge-bot#features

@crertel
Copy link
Contributor Author

crertel commented Oct 13, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@crertel merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@Lassulus Lassulus merged commit ae88a07 into NixOS:master Oct 13, 2024
10 of 11 checks passed
@eeedean
Copy link
Contributor

eeedean commented Oct 13, 2024

I could swear, I already used this bad boy to merge one of my PRs… I‘ll investigate again 😅

@eeedean
Copy link
Contributor

eeedean commented Oct 13, 2024

@crertel , merge bot seems to be an in-progress-RFC and not sharp yep. Currently, it does only mention the merge queue issue, as seen. That does at least motivate some commiter (in this case Lassalus, who also is involved in creation of the bot and RFC — Thanks!!) to press the holy button.

See for more information here.

Anyway: seems reasonable to let the bot put an approved PR into the merge queue. Works as designed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants