-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lmstudio: 0.3.3 -> 0.3.4 #347599
lmstudio: 0.3.3 -> 0.3.4 #347599
Conversation
|
pkgs/by-name/lm/lmstudio/darwin.nix
Outdated
@@ -10,7 +10,7 @@ stdenv.mkDerivation { | |||
|
|||
src = fetchurl { | |||
url = "https://releases.lmstudio.ai/darwin/arm64/${version}/LM-Studio-${version}-arm64.dmg"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- url needs change including build revision:
https://releases.lmstudio.ai/darwin/arm64/${version}/3/LM-Studio-${version}-arm64.dmg
maybe, we even want to put the build revision into its own variable, as it is present in both URLs now?
https://releases.lmstudio.ai/darwin/arm64/${version}/${build-revision}/LM-Studio-${version}-arm64.dmg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps--but the thing is, they keep changing around the URLs on us (at least for the Linux folks--Mac seems stabler). I'm kinda wondering if we should go the other way and just hardcode the URL every time until they get their act together.
@eeedean thanks for catching that bad URL, must've fat-fingered it. Not on Mac so my testing there isn't super thorough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 347599
aarch64-darwin
✅ 1 package built:
- lmstudio
x86_64-linux
✅ 1 package built:
- lmstudio
- I would appreciate a squash of the commits, please. Then it's perfect imo. 🐱
Edit: Also sorry for taking so long to get back to you
e5ec8e0
to
c516346
Compare
c516346
to
196fbd4
Compare
@eeedean done! |
In case, you don’t know this friend, yet: https://github.com/nixos/nixpkgs-merge-bot#features |
@NixOS/nixpkgs-merge-bot merge |
I could swear, I already used this bad boy to merge one of my PRs… I‘ll investigate again 😅 |
@crertel , merge bot seems to be an in-progress-RFC and not sharp yep. Currently, it does only mention the merge queue issue, as seen. That does at least motivate some commiter (in this case Lassalus, who also is involved in creation of the bot and RFC — Thanks!!) to press the holy button. See for more information here. Anyway: seems reasonable to let the bot put an approved PR into the merge queue. Works as designed! |
Changes
Full Changelog
Summary
What’s new in 0.3.4:
New
Bug Fixes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.