Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.protobuf: propagate pkgs.protobuf #349270

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 17, 2024

Things done

Previously to the latest staging-next merge, python3Packages.protobuf was pointing to python-modules/protobuf/4.nix.
This derivation, apart from building the python bindings for protobuf from source, does propagate the actual pkgs/protobuf package which provides the downstream dependents with the protoc binary.

Now, the current python3Packages.protobuf package is a new derivation which does not propagate pkgs.protobuf.
Hence, several packages that rely on protoc now fail to build.

This PR reintroduces this propagation of pkgs.protobuf.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE: Splicing

Unless there's even more magic that I know not of, I think splicing doesn't work this way yet:

image

But maybe that's what @Artturin's #349316 would change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE: Splicing

Unless there's even more magic that I know not of, I think splicing doesn't work this way yet:

image

But maybe that's what @Artturin's #349316 would change?

That's normal, derivations inside derivations aren't spliced

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my interpretation: the argument passed via newScope here is spliced, and the argument passed in overrides isn't

@vcunat vcunat merged commit 8a83a96 into NixOS:staging-next Oct 21, 2024
30 checks passed
@vcunat
Copy link
Member

vcunat commented Oct 21, 2024

Sounds good to me. Feel free to keep improving :-)

@GaetanLepage GaetanLepage deleted the protobuf branch October 21, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants