-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.protobuf: propagate pkgs.protobuf #349270
Conversation
827c44b
to
5558ca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my interpretation: the argument passed via newScope
here is spliced, and the argument passed in overrides isn't
5558ca4
to
c3777a8
Compare
Sounds good to me. Feel free to keep improving :-) |
Things done
Previously to the latest
staging-next
merge,python3Packages.protobuf
was pointing topython-modules/protobuf/4.nix
.This derivation, apart from building the python bindings for protobuf from source, does propagate the actual
pkgs/protobuf
package which provides the downstream dependents with theprotoc
binary.Now, the current
python3Packages.protobuf
package is a new derivation which does not propagatepkgs.protobuf
.Hence, several packages that rely on
protoc
now fail to build.This PR reintroduces this propagation of
pkgs.protobuf
.nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.