antares: modernize; remove electron override #350627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I'm concerned all (currently) available Electron versions are supported, so we can remove the override. Should an issue arise, the override can be added back.
NotAShelf
force-pushed
the
bump-antares
branch
from
525aeea
to
eef5536
Compare
wegank
added
12.approvals: 1
21 tasks
|
This is broken on |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-350627-to-release-24.05 origin/release-24.05
cd .worktree/backport-350627-to-release-24.05
git switch --create backport-350627-to-release-24.05
git cherry-pick -x a89407bf011bca055b7b921e2f4889cf41092609 eef5536acb98956019ae3c5a8e8b205d99822cef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Electron override for antares in
all-packages.nix. While I waslooking at the derivation, I also updated some parts to better reflect current
nixpkgs standards and added changelog.
See: #350549