Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyright: 1.1.382 -> 1.1.391 #350940

Merged
merged 1 commit into from
Dec 20, 2024
Merged

pyright: 1.1.382 -> 1.1.391 #350940

merged 1 commit into from
Dec 20, 2024

Conversation

kalekseev
Copy link
Contributor

@kalekseev kalekseev commented Oct 24, 2024 •
edited
Loading

Things done

  • Updated update.sh script to handle root package.json updates
  • Updated to pyright to latest version using the script
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Oct 24, 2024
@kalekseev kalekseev changed the title pyright: 1.1.382 -> 1.1.386 pyright: 1.1.382 -> 1.1.387 Oct 30, 2024
@kalekseev kalekseev changed the title pyright: 1.1.382 -> 1.1.387 pyright: 1.1.382 -> 1.1.389 Nov 13, 2024
@kalekseev kalekseev changed the title pyright: 1.1.382 -> 1.1.389 pyright: 1.1.382 -> 1.1.390 Dec 5, 2024
@kalekseev kalekseev changed the title pyright: 1.1.382 -> 1.1.390 pyright: 1.1.382 -> 1.1.391 Dec 20, 2024
@kalekseev kalekseev changed the base branch from master to staging December 20, 2024 04:53
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: vim 6.topic: vscode 6.topic: lib The Nixpkgs function library and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde labels Dec 20, 2024
@github-actions github-actions bot removed 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: vim 6.topic: vscode 6.topic: lib The Nixpkgs function library labels Dec 20, 2024
@kalekseev
Copy link
Contributor Author

kalekseev commented Dec 20, 2024 •
edited
Loading

Why people add linter as build dependency? Now 2500+ packages depend on linter (that includes breaking changes every other release) and new versions have to go through staging, nice...

@kalekseev kalekseev force-pushed the fix-pyright branch 2 times, most recently from 5770d66 to 84b4147 Compare December 20, 2024 06:30
@kalekseev
Copy link
Contributor Author

@GaetanLepage can you please merge this one? I fixed update.sh to restore automatic updates via r-ryantm bot.

GaetanLepage
GaetanLepage reviewed Dec 20, 2024
View reviewed changes
pkgs/by-name/py/pyright/package.nix Outdated

let
version = "1.1.382";
version = "1.1.391";

src = fetchFromGitHub {
owner = "Microsoft";
repo = "pyright";
rev = "${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "${version}";
tag = version

Could you also use src.tag in meta.changelog too please ?

GaetanLepage
GaetanLepage approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@GaetanLepage
Copy link
Contributor

@ofborg build pyright

@GaetanLepage GaetanLepage merged commit 8de04b3 into NixOS:staging Dec 20, 2024
24 of 28 checks passed
@kalekseev kalekseev mentioned this pull request Jan 8, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 2501-5000 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalekseev @GaetanLepage