python3Packages.orange3: setup direct dependencies to fetch from GitHub + bump #354279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
|
lucasew
force-pushed
the
20241107-upd-orange3
branch
2 times, most recently
from
d89dea3 to
f89bd30
Compare
lucasew
changed the title
|
lucasew
requested review from
fabaff,
mweinelt,
thiagokokada and
GaetanLepage
GaetanLepage
requested changes
Nov 19, 2024
|
|
||
| nativeCheckInputs = [ pytestCheckHook ]; | ||
|
|
||
| passthru.updateScript = gitUpdater { }; |
There was a problem hiding this comment.
Why not nix-update-script ?
There was a problem hiding this comment.
Simpler, and the actual code is in nixpkgs already. BTW there is a generic updater that you can setup by just giving a command that list the versions available
There was a problem hiding this comment.
Ok, I was not aware of that. So basically it is (or should be) recommended over nix-update-script for all packages using fetchFromGit* ?
There was a problem hiding this comment.
Anything using git should work.
If they use some kind of tag prefix such as v or sscg- then you pass it using the rev-prefix parameter and that's it.
If you want always the latest commit then you use unstableGitUpdater, and there is genericUpdater when the source is not git, you basically pass a script to list versions then it takes the latest one by comparison then change the hashes automatically. This version list is a bit clunky because the system expects you to pass a expression that takes package information as an argument, I did an example of that in #354277 tho.
There was a problem hiding this comment.
Ok good to know ! Thank you for the explanation :)
There was a problem hiding this comment.
Actually, I think that specifying the updater is useless for packages under python3Packages as they all inherit an updater (nix-update-script I think) by default.
Hence, I would actually get rid of those.
Maybe @mweinelt can confirm.
lucasew
force-pushed
the
20241107-upd-orange3
branch
2 times, most recently
from
0408ca6 to
4c88852
Compare
|
|
GaetanLepage
requested changes
Nov 20, 2024
|
|
||
| nativeCheckInputs = [ pytestCheckHook ]; | ||
|
|
||
| passthru.updateScript = gitUpdater { }; |
There was a problem hiding this comment.
Actually, I think that specifying the updater is useless for packages under python3Packages as they all inherit an updater (nix-update-script I think) by default.
Hence, I would actually get rid of those.
Maybe @mweinelt can confirm.
|
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
lucasew
force-pushed
the
20241107-upd-orange3
branch
from
c4b59cb to
91ab556
Compare
|
GaetanLepage
requested changes
Dec 30, 2024
Signed-off-by: lucasew <[email protected]>
|
|
catboost is broken, that's why orange is failing |
|
|
Signed-off-by: lucasew <[email protected]>
GaetanLepage
force-pushed
the
20241107-upd-orange3
branch
from
ad54023 to
33c1a1d
Compare
|
GaetanLepage
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.