Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static-web-server: 2.33.1 -> 2.34.0, add misilelab to maintainers #361614

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

MisileLab
Copy link
Contributor

@MisileLab MisileLab commented Dec 4, 2024

https://github.com/static-web-server/static-web-server/releases/tag/v2.34.0
I also deleted unused input.
Edit: maintainers doesn't respond, so I want to adopt package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MisileLab MisileLab changed the title static-web-server: 2.33.1 -> 2.34.0 static-web-server: 2.33.1 -> 2.34.0, add misilelab to maintainers Dec 30, 2024
@MisileLab
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361614


x86_64-linux

✅ 1 package built:
  • static-web-server

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 30, 2024
@donovanglover donovanglover added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 1, 2025
@ck3d ck3d merged commit 02bf4b7 into NixOS:master Jan 1, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants