Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdm-settings: 4.4 -> 5.0 #361656

Merged
merged 1 commit into from
Jan 31, 2025
Merged

gdm-settings: 4.4 -> 5.0 #361656

merged 1 commit into from
Jan 31, 2025

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Dec 4, 2024

Changelog: https://github.com/gdm-settings/gdm-settings/releases/tag/v5.0
Diff: gdm-settings/gdm-settings@v4.4...v5.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo added the backport release-24.11 Backport PR automatically label Dec 4, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 4, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 4, 2024
@getchoo getchoo force-pushed the pkgs/gdm-settings/5.0 branch from 0f3b085 to 4161c20 Compare December 16, 2024 10:34
@getchoo getchoo marked this pull request as ready for review December 16, 2024 10:35
donovanglover
donovanglover approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@donovanglover donovanglover added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 1, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@donovanglover
Copy link
Member

Merge conflict from #368177

@getchoo getchoo force-pushed the pkgs/gdm-settings/5.0 branch from 4161c20 to 5f9c601 Compare January 31, 2025 15:49
@getchoo getchoo removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 31, 2025
@getchoo getchoo requested a review from donovanglover January 31, 2025 15:49
@donovanglover donovanglover merged commit 8bb03fb into NixOS:master Jan 31, 2025
24 of 27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 31, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 31, 2025
Open
1 task
@getchoo getchoo deleted the pkgs/gdm-settings/5.0 branch January 31, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donovanglover donovanglover donovanglover approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@getchoo @donovanglover @wegank