Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aw-qt: fix build #366195

Merged
merged 1 commit into from
Dec 19, 2024
Merged

aw-qt: fix build #366195

merged 1 commit into from
Dec 19, 2024

Conversation

LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Dec 18, 2024 •
edited
Loading

This broke in f16215f (pyqt6 update) because setuptools is no longer a propagated build input. The fix is trivial.

Breakage nixpkgs-review in #364735 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 18, 2024
@LordGrimmauld LordGrimmauld mentioned this pull request Dec 18, 2024
Closed
13 tasks
@LordGrimmauld
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366195

x86_64-linux

✅ 3 packages built:
  • activitywatch
  • aw-qt
  • aw-qt.dist

@LordGrimmauld LordGrimmauld added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 18, 2024
@ofborg ofborg bot requested a review from huantianad December 19, 2024 03:09
@r-vdp r-vdp merged commit 9c30e7a into NixOS:master Dec 19, 2024
50 of 51 checks passed
@OPNA2608
Copy link
Contributor

The pyqt6 bump was backported to current stable (#364735 (comment)), so this is still broken there. Backporting this to stable too.

@OPNA2608 OPNA2608 added the backport release-24.11 Backport PR automatically label Dec 27, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 27, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huantianad huantianad Awaiting requested review from huantianad

Assignees
No one assigned
Labels
0.kind: build failure A package fails to build 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LordGrimmauld @OPNA2608 @huantianad @r-vdp