tests.overriding: format with nixfmt-rfc-style and categorize #366583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split tests in the let-in block into tests-stdenv, tests-go, and tests-python. Place the dependent variables into the let-in block of each category. This chore commit causes no rebuilds.
github-actions
bot
added
10.rebuild-darwin: 0
|
13 tasks
infinisil
approved these changes
Jan 14, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-366583-to-release-24.11 origin/release-24.11
cd .worktree/backport-366583-to-release-24.11
git switch --create backport-366583-to-release-24.11
git cherry-pick -x 662cf493f0bbb6ceaaf32b96fea3636064e8d850 9e66d6ce585636cd243c91a54e09cb7faae5c021 |
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats the Nix expression of
tests.overridingaccording to NixOS/rfcs#166 and categorises the test cases according to the build helpers they are testing against.This chore PR should cause no rebuild (aside from
nixos-install-tool, which depends on the whole Nixpkgs codebase). It would be easier to review each commit separately.I want to backport this PR to make adding test cases for subsequent PRs that fix package overriding easier.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.