Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.mlx: init at 0.9 #366892

Merged
merged 2 commits into from
Dec 21, 2024
Merged

ocamlPackages.mlx: init at 0.9 #366892

merged 2 commits into from
Dec 21, 2024

Conversation

Denommus
Copy link
Contributor

https://github.com/ocaml-mlx/mlx

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: ocaml 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Dec 20, 2024
@nix-owners nix-owners bot requested a review from ulrikstrid December 20, 2024 18:30
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 20, 2024
@ulrikstrid
Copy link
Member

ulrikstrid commented Dec 20, 2024

Please split into two commits, one for adding you as maintainer and the other for the package.

I don't remember what the first commit should be named but the package commit should be ocamlPackages.mlx: init at 0.9

@Denommus Denommus changed the title mlx: init at 0.9 ocamlPackages.mlx: init at 0.9 Dec 21, 2024
@Denommus
Copy link
Contributor Author

@ulrikstrid done

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 21, 2024
@ulrikstrid ulrikstrid merged commit 9a6ed10 into NixOS:master Dec 21, 2024
46 checks passed
@anmonteiro
Copy link
Member

this version doesn't build on OCaml 5.3

@ulrikstrid
Copy link
Member

@anmonteiro do you have a fix in the overlays or should we just set max version constraint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: ocaml 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants