neovim-require-check-hook: include check inputs; vimPlugins: nativeCheckInputs -> checkInputs #367802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only including the nativeCheckInputs, but it would be more ergonomical to allow people to define checkInputs so they don't accidentally disable the check phase.
nix-owners
bot
requested review from
figsoda,
GaetanLepage,
manveru,
mrcjkb,
PerchunPak and
rvolosatovs
13 tasks
|
Merging with #368843 since that is a large rebuild too |
khaneliman
added a commit
to khaneliman/nixpkgs
that referenced
this pull request
Dec 28, 2024
…eckInputs -> checkInputs (NixOS#367802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Including checkInputs in the test and migrating current examples to use checkInputs over nativeCheckInputs because it's too easy to accidentally disable the check via trying to add inputs to fix a test case.
Since this is a full plugin set rebuild, going to see what other tweaks can be made to reduce amount of rebuilds we do.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.