vulkan-memory-allocator: use tag in src, do not reference src #368245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
paparodeo
reviewed
Dec 26, 2024
| @@ -4,6 +4,7 @@ | |||
| fetchFromGitHub, | |||
| fetchpatch, | |||
| cmake, | |||
| gitUpdater, | |||
There was a problem hiding this comment.
this is probably unnecessary. nix-update will handle git releases fine (if they are just tags and not releases that's different): https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/releases
there's no entry here: https://nixpkgs-update-logs.nix-community.org but that might just be that the last update was in may and the package was added in June so there's been nothing to do.
Signed-off-by: lucasew <[email protected]>
lucasew
force-pushed
the
20241225-fix-vulkan-memory-allocator
branch
from
e23a48f to
5c7843f
Compare
lucasew
changed the title
GaetanLepage
approved these changes
Dec 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.