Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lanzaboote-tool: use tag in src, do not reference src, remove with lib in meta, add update script, 0.3.0 -> 0.4.1 #368246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lanzaboote-tool: use tag in src, do not reference src, remove with lib in meta, add update script, 0.3.0 -> 0.4.1 #368246

wants to merge 2 commits into from
+15 −9

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Dec 26, 2024

  • lanzaboote-tool: use tag in src, do not reference src, remove with lib in meta, add update script
  • lanzaboote-tool: 0.3.0 -> 0.4.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 26, 2024
@ofborg ofborg bot requested review from nikstur and RaitoBezarius December 26, 2024 06:21
@lucasew
Copy link
Contributor Author

lucasew commented Dec 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368246

x86_64-linux

❌ 1 package failed to build:
  • lanzaboote-tool

@lucasew lucasew force-pushed the 20241225-fix-lanzaboote-tool branch from 2d12f27 to 1931798 Compare December 30, 2024 02:22
@lucasew lucasew marked this pull request as ready for review December 30, 2024 02:23
@lucasew
Copy link
Contributor Author

lucasew commented Dec 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368246

x86_64-linux

⏩ 8 packages marked as broken and skipped:
  • rocmPackages.migraphx
  • rocmPackages.mivisionx
  • rocmPackages.mivisionx-cpu
  • rocmPackages.mivisionx-hip
  • rocmPackages_5.mivisionx
  • rocmPackages_5.mivisionx-cpu
  • rocmPackages_5.mivisionx-hip
  • rocmPackages_5.mivisionx-opencl
❌ 1 package failed to build:
  • rocmPackages_5.migraphx
✅ 10 packages built:
  • ayatana-indicator-display
  • cppcheck
  • cppcheck.man
  • lanzaboote-tool
  • libcangjie
  • libsForQt5.kdev-php
  • libsForQt5.kdev-python
  • libsForQt5.kdevelop
  • libsForQt5.kdevelop-unwrapped
  • proto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikstur nikstur Awaiting requested review from nikstur

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucasew