Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcms2: Stop propagating dependencies #368600

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 27, 2024

These were propagated from the beginning (2d9d69c)
but I cannot see any reason for that. They are not mentioned in the pkg-config file.
And the three libraries only appear to be used by jpgicc/tificc programs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

These were propagated from the beginning (2d9d69c)
but I cannot see any reason for that. They are not mentioned in the pkg-config file.
And the three libraries only appear to be used by jpgicc/tificc programs.
@jtojnar jtojnar merged commit a03cc60 into NixOS:staging Dec 31, 2024
42 of 44 checks passed
@jtojnar jtojnar deleted the lcm2-unprop branch December 31, 2024 19:01
@trofi
Copy link
Contributor

trofi commented Jan 1, 2025

Bisect says that caused poppler build regression in staging. Proposed the possible fix as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants