[Backport release-24.11] swift: source darwin-sdk-setup.bash #368937

nixpkgs-ci · 2024-12-28T22:14:09Z

Bot-based backport to release-24.11, triggered by a label in #360207.

Before merging, ensure that this backport is acceptable for the release.
- Even as a non-commiter, if you find that it is not acceptable, leave a comment.

Fixes builds using xcbuild that redefine SDKROOT in the xcbuild wrapper. SDKROOT will be set using the same logic that other wrappers use. (cherry picked from commit c578c48)

wolfgangwalther · 2025-01-01T23:08:03Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368937

`x86_64-linux`

✅ 24 packages built:

deadbeef
deadbeef-with-plugins
ghidra-extensions.ghidraninja-ghidra-scripts
protoc-gen-swift
sourcekit-lsp (swiftPackages.sourcekit-lsp)
swift (swiftPackages.swift)
swiftPackages.Dispatch (swift-corelibs-libdispatch)
swiftPackages.Dispatch.dev (swift-corelibs-libdispatch.dev)
swiftPackages.Dispatch.man (swift-corelibs-libdispatch.man)
swift-format (swiftPackages.swift-format)
swift.man (swiftPackages.swift.man)
swiftPackages.Foundation
swiftPackages.Foundation.dev
swiftPackages.XCTest
swiftPackages.swift-docc
swiftPackages.swift-driver
swiftPackages.swift-unwrapped
swiftPackages.swift-unwrapped.dev
swiftPackages.swift-unwrapped.doc
swiftPackages.swift-unwrapped.lib
swiftPackages.swift-unwrapped.man
swiftPackages.swiftNoSwiftDriver
swiftPackages.swiftNoSwiftDriver.man
swiftpm (swiftPackages.swiftpm)

`x86_64-darwin`

⏩ 30 packages marked as broken and skipped:

anilibria-winmaclinux
anki
anki.dist
anki.doc
anki.man
deepin.dde-gsettings-schemas
flet-client-flutter
flet-client-flutter.debug
flet-client-flutter.pubcache
haruna
jellyfin-mpv-shim
jellyfin-mpv-shim.dist
ki
ki.dist
libsForQt5.tokodon
mnemosyne
mnemosyne.dist
mpc-qt
plasma5Packages.tokodon
python311Packages.flet
python311Packages.flet-runtime
python311Packages.flet-runtime.dist
python311Packages.flet.dist
python312Packages.flet
python312Packages.flet-runtime
python312Packages.flet-runtime.dist
python312Packages.flet.dist
sublime-music
sublime-music.dist
ytui-music

❌ 22 packages failed to build:

dotnetCorePackages.dotnet_8.aspnetcore
dotnetCorePackages.dotnet_8.aspnetcore.man
dotnetCorePackages.dotnet_8.runtime
dotnetCorePackages.dotnet_8.runtime.man
dotnetCorePackages.dotnet_8.sdk
dotnetCorePackages.dotnet_8.sdk.man
dotnetCorePackages.dotnet_8.vmr
dotnetCorePackages.dotnet_8.vmr.man
dotnetCorePackages.dotnet_9.aspnetcore
dotnetCorePackages.dotnet_9.aspnetcore.man
dotnetCorePackages.dotnet_9.runtime
dotnetCorePackages.dotnet_9.runtime.man
dotnetCorePackages.dotnet_9.sdk
dotnetCorePackages.dotnet_9.sdk.man
dotnetCorePackages.dotnet_9.vmr
dotnetCorePackages.dotnet_9.vmr.man
hydrus
hydrus.doc
jellyfin-media-player
needle
plex-media-player
yafc-ce

✅ 54 packages built:

ani-cli
cplay-ng
cplay-ng.dist
curseradio
curseradio.dist
darwin.openwith
dmlive
dra-cla
ff2mpv
ff2mpv-go
ghidra-extensions.ghidraninja-ghidra-scripts
gonic
gtk-pipe-viewer
gtk-pipe-viewer.devdoc
invidtui
klipperscreen
mov-cli
mov-cli.dist
mpv
mpv-unwrapped
mpv-unwrapped.dev
mpv-unwrapped.doc
mpv-unwrapped.man
pipe-viewer
pipe-viewer.devdoc
protoc-gen-swift
python311Packages.mpv
python311Packages.mpv.dist
python312Packages.mpv
python312Packages.mpv.dist
somafm-cli
sourcekit-lsp (swiftPackages.sourcekit-lsp)
subtitleedit
supersonic
swift (swiftPackages.swift)
swift-format (swiftPackages.swift-format)
swift.man (swiftPackages.swift.man)
swiftPackages.XCTest
swiftPackages.swift-docc
swiftPackages.swift-driver
swiftPackages.swift-unwrapped
swiftPackages.swift-unwrapped.dev
swiftPackages.swift-unwrapped.doc
swiftPackages.swift-unwrapped.lib
swiftPackages.swift-unwrapped.man
swiftPackages.swiftNoSwiftDriver
swiftPackages.swiftNoSwiftDriver.man
swiftpm (swiftPackages.swiftpm)
termusic
tomato-c
wtwitch
xcodes
youtube-tui
ytfzf

`aarch64-darwin`

⏩ 30 packages marked as broken and skipped:

anilibria-winmaclinux
anki
anki.dist
anki.doc
anki.man
deepin.dde-gsettings-schemas
flet-client-flutter
flet-client-flutter.debug
flet-client-flutter.pubcache
haruna
jellyfin-mpv-shim
jellyfin-mpv-shim.dist
ki
ki.dist
libsForQt5.tokodon
mnemosyne
mnemosyne.dist
mpc-qt
plasma5Packages.tokodon
python311Packages.flet
python311Packages.flet-runtime
python311Packages.flet-runtime.dist
python311Packages.flet.dist
python312Packages.flet
python312Packages.flet-runtime
python312Packages.flet-runtime.dist
python312Packages.flet.dist
sublime-music
sublime-music.dist
ytui-music

❌ 22 packages failed to build:

dotnetCorePackages.dotnet_8.aspnetcore
dotnetCorePackages.dotnet_8.aspnetcore.man
dotnetCorePackages.dotnet_8.runtime
dotnetCorePackages.dotnet_8.runtime.man
dotnetCorePackages.dotnet_8.sdk
dotnetCorePackages.dotnet_8.sdk.man
dotnetCorePackages.dotnet_8.vmr
dotnetCorePackages.dotnet_8.vmr.man
dotnetCorePackages.dotnet_9.aspnetcore
dotnetCorePackages.dotnet_9.aspnetcore.man
dotnetCorePackages.dotnet_9.runtime
dotnetCorePackages.dotnet_9.runtime.man
dotnetCorePackages.dotnet_9.sdk
dotnetCorePackages.dotnet_9.sdk.man
dotnetCorePackages.dotnet_9.vmr
dotnetCorePackages.dotnet_9.vmr.man
hydrus
hydrus.doc
jellyfin-media-player
needle
plex-media-player
yafc-ce

✅ 56 packages built:

ani-cli
cplay-ng
cplay-ng.dist
curseradio
curseradio.dist
dark-mode-notify
darwin.openwith
dmlive
dockutil
dra-cla
ff2mpv
ff2mpv-go
ghidra-extensions.ghidraninja-ghidra-scripts
gonic
gtk-pipe-viewer
gtk-pipe-viewer.devdoc
invidtui
klipperscreen
mov-cli
mov-cli.dist
mpv
mpv-unwrapped
mpv-unwrapped.dev
mpv-unwrapped.doc
mpv-unwrapped.man
pipe-viewer
pipe-viewer.devdoc
protoc-gen-swift
python311Packages.mpv
python311Packages.mpv.dist
python312Packages.mpv
python312Packages.mpv.dist
somafm-cli
sourcekit-lsp (swiftPackages.sourcekit-lsp)
subtitleedit
supersonic
swift (swiftPackages.swift)
swift-format (swiftPackages.swift-format)
swift.man (swiftPackages.swift.man)
swiftPackages.XCTest
swiftPackages.swift-docc
swiftPackages.swift-driver
swiftPackages.swift-unwrapped
swiftPackages.swift-unwrapped.dev
swiftPackages.swift-unwrapped.doc
swiftPackages.swift-unwrapped.lib
swiftPackages.swift-unwrapped.man
swiftPackages.swiftNoSwiftDriver
swiftPackages.swiftNoSwiftDriver.man
swiftpm (swiftPackages.swiftpm)
termusic
tomato-c
wtwitch
xcodes
youtube-tui
ytfzf

wolfgangwalther · 2025-01-02T16:57:29Z

@reckenrode Build failure for needle seems to be a regression of this PR:

error: 'generator': Invalid manifest (compiled with: ["/nix/store/8106ml5ml07j0157rcxnxx53ppiqw0lj-swift-wrapper-5.8/bin/swiftc", "-vfsoverlay", "/private/tmp/>
error: compile command failed due to signal 8 (use -v to see invocation)
<unknown>:0: warning: overriding '-mmacos-version-min=10.15' option with '-target x86_64-apple-macosx10.15.4'
/nix/store/kdhym32zyhxb76g4a9cl7qh35cyljb96-apple-sdk-13.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/H>
#import <CoreServices/CoreServices.h>
        ^
/nix/store/kdhym32zyhxb76g4a9cl7qh35cyljb96-apple-sdk-13.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework>
#include <emmintrin.h>
         ^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "immintrin.h"
        ^
/nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/immintrin.h:31:10: note: in file included from /nix/store/raqax5qp65an4j>
#include <emmintrin.h>
         ^
/nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/emmintrin.h:43:9: error: _Float16 is not supported on this target
typedef _Float16 __v8hf __attribute__((__vector_size__(16), __aligned__(16)));
        ^
/nix/store/kdhym32zyhxb76g4a9cl7qh35cyljb96-apple-sdk-13.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/H>
#import <CoreServices/CoreServices.h>
        ^
/nix/store/kdhym32zyhxb76g4a9cl7qh35cyljb96-apple-sdk-13.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework>
#include <emmintrin.h>
         ^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "immintrin.h"
        ^
/nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/immintrin.h:31:10: note: in file included from /nix/store/raqax5qp65an4j>
#include <emmintrin.h>
         ^
/nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/emmintrin.h:44:9: error: _Float16 is not supported on this target
typedef _Float16 __m128h __attribute__((__vector_size__(16), __aligned__(16)));
        ^
/nix/store/kdhym32zyhxb76g4a9cl7qh35cyljb96-apple-sdk-13.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/H>
#import <CoreServices/CoreServices.h>
        ^
/nix/store/kdhym32zyhxb76g4a9cl7qh35cyljb96-apple-sdk-13.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework>
#include <emmintrin.h>
         ^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "immintrin.h"
        ^
/nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/immintrin.h:31:10: note: in file included from /nix/store/raqax5qp65an4j>
#include <emmintrin.h>
         ^
/nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/emmintrin.h:45:9: error: _Float16 is not supported on this target
typedef _Float16 __m128h_u __attribute__((__vector_size__(16), __aligned__(1)));
        ^
/nix/store/kdhym32zyhxb76g4a9cl7qh35cyljb96-apple-sdk-13.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/H>
#import <CoreServices/CoreServices.h>
        ^
/nix/store/kdhym32zyhxb76g4a9cl7qh35cyljb96-apple-sdk-13.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework>
#include <emmintrin.h>
         ^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "immintrin.h"
        ^
/nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/immintrin.h:31:10: note: in file included from /nix/store/raqax5qp65an4j>
#include <emmintrin.h>
         ^
/nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/emmintrin.h:47:9: error: __bf16 is not supported on this target
typedef __bf16 __v8bf __attribute__((__vector_size__(16), __aligned__(16)));
        ^
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.
Stack dump:
0.      /nix/store/raqax5qp65an4jcwj1bzd5lq589ywpg0-clang-wrapper-16.0.6/resource-root/include/emmintrin.h:47:76: current parser token ';'
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  .swift-frontend-wrapped  0x00000001091f52bb llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 59
1  .swift-frontend-wrapped  0x00000001091f41b7 llvm::sys::RunSignalHandlers() + 279
2  .swift-frontend-wrapped  0x00000001091f59cb SignalHandler(int) + 363
3  libsystem_platform.dylib 0x00007ff801452e1d _sigtramp + 29
4  libsystem_platform.dylib 0x0000000000000001 _sigtramp + 18446603370559623681
5  .swift-frontend-wrapped  0x00000001080ea77e processTypeAttrs((anonymous namespace)::TypeProcessingState&, clang::QualType&, TypeAttrLocation, clang::ParsedA>
6  .swift-frontend-wrapped  0x00000001080e2c17 GetFullTypeForDeclarator((anonymous namespace)::TypeProcessingState&, clang::QualType, clang::TypeSourceInfo*) +>
7  .swift-frontend-wrapped  0x00000001080d9f6c clang::Sema::GetTypeForDeclarator(clang::Declarator&, clang::Scope*) + 716
8  .swift-frontend-wrapped  0x0000000107a78a46 clang::Sema::HandleDeclarator(clang::Scope*, clang::Declarator&, llvm::MutableArrayRef<clang::TemplateParameterL>
9  .swift-frontend-wrapped  0x0000000107a7853a clang::Sema::ActOnDeclarator(clang::Scope*, clang::Declarator&) + 26
10 .swift-frontend-wrapped  0x00000001076168b4 clang::Parser::ParseDeclarationAfterDeclaratorAndAttributes(clang::Declarator&, clang::Parser::ParsedTemplateInf>
11 .swift-frontend-wrapped  0x00000001076145b2 clang::Parser::ParseDeclGroup(clang::ParsingDeclSpec&, clang::DeclaratorContext, clang::SourceLocation*, clang::>
12 .swift-frontend-wrapped  0x000000010760dad6 clang::Parser::ParseSimpleDeclaration(clang::DeclaratorContext, clang::SourceLocation&, clang::ParsedAttributes&>
13 .swift-frontend-wrapped  0x000000010760d402 clang::Parser::ParseDeclaration(clang::DeclaratorContext, clang::SourceLocation&, clang::ParsedAttributes&, clan>
14 .swift-frontend-wrapped  0x00000001076d326b clang::Parser::ParseExternalDeclaration(clang::ParsedAttributes&, clang::ParsingDeclSpec*) + 203
15 .swift-frontend-wrapped  0x00000001076d1855 clang::Parser::ParseTopLevelDecl(clang::OpaquePtr<clang::DeclGroupRef>&, clang::Sema::ModuleImportState&) + 853
16 .swift-frontend-wrapped  0x00000001075f7bde clang::ParseAST(clang::Sema&, bool, bool) + 798
17 .swift-frontend-wrapped  0x00000001073ff9a8 clang::FrontendAction::Execute() + 104
18 .swift-frontend-wrapped  0x00000001073747ac clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) + 860
19 .swift-frontend-wrapped  0x000000010737f7d0 void llvm::function_ref<void ()>::callback_fn<compileModuleImpl(clang::CompilerInstance&, clang::SourceLocation,>
20 .swift-frontend-wrapped  0x0000000109131ab3 llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) + 227
21 .swift-frontend-wrapped  0x0000000109131bf0 RunSafelyOnThread_Dispatch(void*) + 48
22 .swift-frontend-wrapped  0x0000000109131d3f void* llvm::thread::ThreadProxy<std::__1::tuple<void (*)(void*), (anonymous namespace)::RunSafelyOnThreadInfo*> >
23 libsystem_pthread.dylib  0x00007ff80141c253 _pthread_start + 99
24 libsystem_pthread.dylib  0x00007ff801417bef thread_start + 15

wolfgangwalther · 2025-01-11T17:50:44Z

Build failure for needle seems to be a regression of this PR:

Trying it this time, it fails for me on release-24.11 as well. So not a regression.

wolfgangwalther · 2025-01-11T17:51:26Z

To the best of my knowledge those failures are not regressions, but already fail on release-24.11. Thus, good to merge.

swift: source darwin-sdk-setup.bash

0d30c0a

Fixes builds using xcbuild that redefine SDKROOT in the xcbuild wrapper. SDKROOT will be set using the same logic that other wrappers use. (cherry picked from commit c578c48)

nixpkgs-ci bot mentioned this pull request Dec 28, 2024

swift: source darwin-sdk-setup.bash #360207

Merged

13 tasks

github-actions bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Dec 28, 2024

ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 29, 2024

wolfgangwalther marked this pull request as draft January 2, 2025 16:57

wolfgangwalther marked this pull request as ready for review January 11, 2025 17:50

wolfgangwalther merged commit 78278e3 into release-24.11 Jan 11, 2025
50 of 52 checks passed

wolfgangwalther deleted the backport-360207-to-release-24.11 branch January 11, 2025 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport release-24.11] swift: source darwin-sdk-setup.bash #368937

[Backport release-24.11] swift: source darwin-sdk-setup.bash #368937

nixpkgs-ci bot commented Dec 28, 2024 •

edited by wolfgangwalther

Loading

wolfgangwalther commented Jan 1, 2025

wolfgangwalther commented Jan 2, 2025

wolfgangwalther commented Jan 11, 2025

wolfgangwalther commented Jan 11, 2025

[Backport release-24.11] swift: source darwin-sdk-setup.bash #368937

[Backport release-24.11] swift: source darwin-sdk-setup.bash #368937

Conversation

nixpkgs-ci bot commented Dec 28, 2024 • edited by wolfgangwalther Loading

wolfgangwalther commented Jan 1, 2025

nixpkgs-review result

x86_64-linux

x86_64-darwin

aarch64-darwin

wolfgangwalther commented Jan 2, 2025

wolfgangwalther commented Jan 11, 2025

wolfgangwalther commented Jan 11, 2025

nixpkgs-ci bot commented Dec 28, 2024 •

edited by wolfgangwalther

Loading

`nixpkgs-review` result

`x86_64-linux`

`x86_64-darwin`

`aarch64-darwin`