Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filen-desktop: init at 3.0.41 #368948

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

smissingham
Copy link

@smissingham smissingham commented Dec 28, 2024

Adding package for Filen Desktop
Packaged from AppImage Release
Closes #213628

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 28, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 28, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 28, 2024
@donovanglover
Copy link
Member

Welcome to nixpkgs! Please add "Closes #213628" to the PR description.

Also see #213628 (comment)

@smissingham
Copy link
Author

smissingham commented Dec 29, 2024

Thanks @donovanglover

I burned a day trying to get the buildNpmPackage function to work but am stuck getting a ENOTCACHED npm error.

Think you could take a look and provide pointers? This is a bit beyond my current abilities.

Here's my current best effort

Below is the build error I can't get past

> npm error code 1
> npm error `npm ci --ignore-scripts` failed
> npm error command bash -c npm ci --ignore-scripts $npmInstallFlags "${npmInstallFlagsArray[@]}" $npmFlags "${npmFlagsArray[@]}" || [ -n "$forceGitDeps" ]
> npm error npm error code ENOTCACHED
> npm error npm error request to https://registry.npmjs.org/yocto-queue failed: cache mode is 'only-if-cached' but no cached response is available.
> npm error npm error A complete log of this run can be found in: /build/cache/_logs/2024-12-29T04_18_53_104Z-debug-0.log
> npm error A complete log of this run can be found in: /build/cache/_logs/2024-12-29T04_18_49_368Z-debug-0.log
>
> ERROR: npm failed to install dependencies
>
> Here are a few things you can try, depending on the error:
> 1. Set `makeCacheWritable = true`
>   Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
> 2. Set `npmFlags = [ "--legacy-peer-deps" ]`

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Filen Desktop
3 participants