Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpris-scrobbler: 0.5.3 -> 0.5.5 #368953

Merged
merged 1 commit into from
Dec 30, 2024
Merged

mpris-scrobbler: 0.5.3 -> 0.5.5 #368953

merged 1 commit into from
Dec 30, 2024

Conversation

ChandlerSwift
Copy link
Contributor

@ChandlerSwift ChandlerSwift commented Dec 28, 2024

0.5.4: https://github.com/mariusor/mpris-scrobbler/releases/tag/v0.5.4
0.5.5: https://github.com/mariusor/mpris-scrobbler/releases/tag/v0.5.5

(specifically, for my use case, fixes mariusor/mpris-scrobbler#101)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • builds on NixOS unstable
./result/bin/mpris-scrobbler -vv                                                                                                                                               
DEBUG   main::loading_config: ok
DEBUG   main::loading_credentials: ok
DEBUG   changed::volume:              yes
DEBUG   changed::position:            yes
DEBUG   changed::playback_status:     yes
DEBUG   changed::track:               yes
DEBUG   events::add_event:now_playing[Spotify] in 0.00s, elapsed 113.68s
DEBUG   events::add_event:queue[Spotify] in 1.00s
INFO    scrobbler::now_playing[Spotify]: Disease//Beartooth//Disease
DEBUG   events::add_event:now_playing[Spotify] in 65.00s, elapsed 113.68s
INFO    scrobbler::scrobble:(   0) Disease//Beartooth//Disease
DEBUG   events::new_queue_length: 0
INFO     api::submitted_to[libre.fm]: ok
INFO     api::submitted_to[libre.fm]: ok
DEBUG   changed::volume:               no
DEBUG   changed::position:             no
DEBUG   changed::playback_status:     yes
DEBUG   changed::track:               yes
  • binaries work in so far that a track by spotify is detected and scrobbled to libre-FM.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 30, 2024
@fpletz fpletz merged commit e821118 into NixOS:master Dec 30, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrobbling long track+album+artist to last.fm fails with "Invalid method signature"
4 participants