coturn: remove unnecessary libpromhttp dependency, fix build #369142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR reworked the prometheus endpoint coturn/coturn#1591 Since the latest release libpromhttp is no longer used |
jvanbruegge
changed the title
jvanbruegge
added a commit
to jvanbruegge/server-config
that referenced
this pull request
Dec 29, 2024
|
|
The ofborg failure is unrelated to this build |
illustris
previously requested changes
Dec 30, 2024
This fixes the coturn build
fpletz
approved these changes
Dec 30, 2024
illustris
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/illustris/.cache/nixpkgs-review/pr-369142-1/nixpkgs nixpkgs-overlays=/tmp/nix-shell-3414400-0/tmpuvfpd4le -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
--------- Impacted packages on 'x86_64-linux' ---------
1 package updated:
coturn
$ nix build --file /nix/store/fljl402absl1lsyqd9w6cslvcxa7xs0z-nixpkgs-review-2.12.0/lib/python3.12/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path 'nixpkgs=/home/illustris/.cache/nixpkgs-review/pr-369142-1/nixpkgs nixpkgs-overlays=/tmp/nix-shell-3414400-0/tmpuvfpd4le' --extra-experimental-features 'nix-command no-url-literals' --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr local-system x86_64-linux --argstr nixpkgs-path /home/illustris/.cache/nixpkgs-review/pr-369142-1/nixpkgs --argstr nixpkgs-config-path /tmp/nix-shell-3414400-0/tmpoy046zt3.nix --argstr attrs-path /home/illustris/.cache/nixpkgs-review/pr-369142-1/attrs.nix
Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/369142
--------- Report for 'x86_64-linux' ---------
1 package built:
coturn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the coturn build
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.