Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meilisearch data dir config #369214

Closed
wants to merge 1,701 commits into from
Closed

Add meilisearch data dir config #369214

wants to merge 1,701 commits into from

Conversation

MatthiasvB
Copy link

@MatthiasvB MatthiasvB commented Dec 29, 2024 •
edited
Loading

Extend the config of the meilisearch module to allow setting a custom location for meilisearch to store its data. This is non-trivial due to the dynamic user that's used here. Fixes #368611 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fpletz and others added 30 commits November 26, 2024 09:02
@fpletz
[24.11] librewolf: 132.0.1 -> 132.0.2-1 (NixOS#358538)
38cbc7d
@erictapen
[Backport release-24.11] radicale: 3.3.0 -> 3.3.1 (NixOS#359019)
a183eed
@ehmry
yggdrasil: 0.5.9 -> 0.5.10
f22d8a1 
(cherry picked from commit beee8b6)
@markuskowa @github-actions
abracadabra: 2.7.0 -> 2.7.1
9ef99f0 
(cherry picked from commit a5b22ac)
@SuperSandro2000 @github-actions
limesctl: drop
ba8cafc 
(cherry picked from commit dee1b88)
@vbgl
ocamlPackages.findlib: 1.9.7 → 1.9.8
397e516 
(cherry picked from commit 3d20b48)
@bobby285271 @github-actions
xfce.xfce4-settings: Fix screen locked but lockscreen invisible after…
4507801 
… suspend

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1077277.

(cherry picked from commit f19e0f7)
@bobby285271
[Backport release-24.11] xfce.xfce4-settings: Fix screen locked but l…
98f4971 
…ockscreen invisible after suspend (NixOS#359272)
@techknowlogick @github-actions
gitea: 1.22.3 -> 1.22.4
39a8e72 
Diff: go-gitea/gitea@v1.22.3...v1.22.4
(cherry picked from commit b17934b)
@Kiskae @github-actions
linuxPackages.nvidiaPackages.production: 550.127.05 -> 550.135
18590ee 
(cherry picked from commit fd66d4a)
@xddxdd @github-actions
llama-cpp: 3887 -> 4154
daa840d 
(cherry picked from commit f0d9bf6)
@pbsds
[Backport release-24.11] python312Packages.skops: disable flaky test (N…
7ce32f0 
…ixOS#358886)
@philiptaron
[Backport release-24.11] llama-cpp: 3887 -> 4154 (NixOS#359296)
d89d713
@emilylange
[Backport release-24.11] chromium: resolve ref to rev for blink versi…
95802fb 
…on string (NixOS#359139)
@pbsds
[Backport release-24.11] duckdb: 1.1.2 -> 1.1.3 (NixOS#358619)
2d2ddf3
@K900 @github-actions
kdePackages: Plasma 6.2.3 -> 6.2.4
907f826 
(cherry picked from commit 9458f06)
@K900
[Backport release-24.11] kdePackages: Plasma 6.2.3 -> 6.2.4 (NixOS#35…
b33045f 
…9305)
@pbsds
[Backport release-24.11] lunatask: 2.0.12 -> 2.0.13 (NixOS#358940)
616d46a
@pbsds @github-actions
nixos/binfmt: add option addEmulatedSystemsToNixSandbox
04c5060 
(cherry picked from commit bbb6e83)
@pbsds
[Backport release-24.11] streamcontroller: Use commit hash to fetch r…
fcf30f5 
…eleases and fix hash (NixOS#358898)
@vbgl
coqPackages.fourcolor: 1.3.1 → 1.4.0
307e66c 
(cherry picked from commit 470e6e6)
@r-ryantm @github-actions
diesel-cli: 2.2.4 -> 2.2.5
b7293cb 
(cherry picked from commit 452ecaa)
@r-ryantm @github-actions
television: 0.5.0 -> 0.5.1
bd45261 
(cherry picked from commit 8171d5b)
@OPNA2608 @github-actions
sunvox: Add back wayback machine fallback src
1ed4bc5 
Save Page Now functionality has been restored, we can now back up the src.

(cherry picked from commit 4a43f36)
@kachick @github-actions
cloudflare-warp: 2024.9.346 -> 2024.11.309
8b1b4b0 
(cherry picked from commit 94b04b2)
@marcusramberg
[Backport release-24.11] cloudflare-warp: 2024.9.346 -> 2024.11.309 (N…
17d0af2 
…ixOS#359362)
@NickCao
[Backport release-24.11] linuxPackages.nvidiaPackages.production: 550…
d4634f6 
….127.05 -> 550.135 (NixOS#359290)
@stigtsp @github-actions
perlPackages.ModuleScanDeps: 1.34 -> 1.37
b436bc3 
(cherry picked from commit 2a1f893)
@uku3lig @github-actions
reposilite: 3.5.18 -> 3.5.19
4f8fa5b 
(cherry picked from commit 05e5594)
@michaelgrahamevans @github-actions
forge-sparks: 0.3.0 -> 0.4.0
e8353e4 
(cherry picked from commit 418f888)
@github-actions github-actions bot added 6.topic: vim 6.topic: ocaml 6.topic: xfce The Xfce Desktop Environment 6.topic: fetch 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: hardware 6.topic: coq "A formal proof management system" 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua 6.topic: testing Tooling for automated testing of packages and modules 6.topic: module system About "NixOS" module system internals 6.topic: systemd 6.topic: vscode 6.topic: lib The Nixpkgs function library 6.topic: games 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET 6.topic: flutter 6.topic: nvidia 6.topic: tcl 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Dec 29, 2024
@nix-owners
Copy link

nix-owners bot commented Dec 29, 2024

The PR's base branch is set to master, but 1700 commits from the release-24.11 branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the release-24.11 branch, change the base branch to release-24.11
  • If the changes should go to the master branch, rebase your PR onto the merge base with the master branch: 
    # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/release-24.11 HEAD)
git rebase --onto 1d95cb5fa7a38717172e090d54338ca8daef8a86 62c435d93bf046a5396f3016472e8f7c8e2aed65
git push --force-with-lease

1 similar comment
@nix-owners
Copy link

nix-owners bot commented Dec 29, 2024

The PR's base branch is set to master, but 1700 commits from the release-24.11 branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the release-24.11 branch, change the base branch to release-24.11
  • If the changes should go to the master branch, rebase your PR onto the merge base with the master branch: 
    # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/release-24.11 HEAD)
git rebase --onto 1d95cb5fa7a38717172e090d54338ca8daef8a86 62c435d93bf046a5396f3016472e8f7c8e2aed65
git push --force-with-lease

@MatthiasvB MatthiasvB closed this Dec 29, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: coq "A formal proof management system" 6.topic: dotnet Language: .NET 6.topic: emacs Text editor 6.topic: fetch 6.topic: flutter 6.topic: games 6.topic: hardware 6.topic: haskell 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: lua 6.topic: module system About "NixOS" module system internals 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: nodejs 6.topic: nvidia 6.topic: ocaml 6.topic: pantheon The Pantheon desktop environment 6.topic: php 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: stdenv Standard environment 6.topic: systemd 6.topic: tcl 6.topic: testing Tooling for automated testing of packages and modules 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: vscode 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meilisearch complains about incorrect "read-only file system" and exhibits unexpected behaviour