Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subversionClient: remove vendored swig 3 files; fix build #369267

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

paparodeo
Copy link
Contributor

fixes: #369143

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@paparodeo
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369267


x86_64-linux

⏩ 4 packages marked as broken and skipped:
  • kdePackages.umbrello
  • kdePackages.umbrello.debug
  • kdePackages.umbrello.dev
  • kdePackages.umbrello.devtools
❌ 1 package failed to build:
  • ikiwiki-full
✅ 57 packages built:
  • apacheHttpdPackages.subversion
  • apacheHttpdPackages.subversion.dev
  • apacheHttpdPackages.subversion.man
  • cabal2nix
  • git-doc (git-doc.debug ,git-doc.doc ,gitFull.doc)
  • gitFull
  • gitFull.debug
  • gitSVN
  • gitSVN.debug
  • gitSVN.doc
  • hydra
  • hydra.doc
  • kdePackages.kdev-php
  • kdePackages.kdev-php.debug
  • kdePackages.kdev-php.dev
  • kdePackages.kdev-php.devtools
  • kdePackages.kdev-python
  • kdePackages.kdev-python.debug
  • kdePackages.kdev-python.dev
  • kdePackages.kdev-python.devtools
  • kdePackages.kdevelop
  • kdePackages.kdevelop.debug
  • kdePackages.kdevelop.dev
  • kdePackages.kdevelop.devtools
  • kdesvn
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • python312Packages.pysvn
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.pysvn
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • thcrap-steam-proton-wrapper
  • vcstool
  • vcstool.dist
  • wp4nix

failed builds also fail on master: https://hydra.nixos.org/build/283179983

@paparodeo paparodeo changed the title subversionClient: remove vendored swig 3.0 files; fix build subversionClient: remove vendored swig 3 files; fix build Dec 30, 2024
@ofborg ofborg bot requested a review from lovek323 December 30, 2024 09:39
Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paparodeo pysvn seems to be broken now.

(accidentally approved, wanted to post a build result for both Darwin systems)

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369267


x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.pysvn
  • python313Packages.pysvn
✅ 38 packages built:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.doc ,gitFull.doc)
  • gitFull
  • gitSVN
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • vcstool
  • vcstool.dist
  • wp4nix

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.pysvn
  • python313Packages.pysvn
✅ 38 packages built:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.doc ,gitFull.doc)
  • gitFull
  • gitSVN
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • vcstool
  • vcstool.dist
  • wp4nix

@matteo-pacini matteo-pacini requested review from matteo-pacini and removed request for matteo-pacini December 30, 2024 22:37
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369267


x86_64-linux

⏩ 4 packages marked as broken and skipped:
  • kdePackages.umbrello
  • kdePackages.umbrello.debug
  • kdePackages.umbrello.dev
  • kdePackages.umbrello.devtools
❌ 1 package failed to build:
  • ikiwiki-full
✅ 58 packages built:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.debug ,git-doc.doc ,gitFull.doc)
  • gitFull
  • gitFull.debug
  • gitSVN
  • gitSVN.debug
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • hydra
  • hydra.doc
  • kdePackages.kdev-php
  • kdePackages.kdev-php.debug
  • kdePackages.kdev-php.dev
  • kdePackages.kdev-php.devtools
  • kdePackages.kdev-python
  • kdePackages.kdev-python.debug
  • kdePackages.kdev-python.dev
  • kdePackages.kdev-python.devtools
  • kdePackages.kdevelop
  • kdePackages.kdevelop.debug
  • kdePackages.kdevelop.dev
  • kdePackages.kdevelop.devtools
  • kdesvn
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • python312Packages.pysvn
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.pysvn
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • thcrap-steam-proton-wrapper
  • vcstool
  • vcstool.dist
  • wp4nix

aarch64-linux

⏩ 4 packages marked as broken and skipped:
  • kdePackages.umbrello
  • kdePackages.umbrello.debug
  • kdePackages.umbrello.dev
  • kdePackages.umbrello.devtools
❌ 1 package failed to build:
  • ikiwiki-full
✅ 58 packages built:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.debug ,git-doc.doc ,gitFull.doc)
  • gitFull
  • gitFull.debug
  • gitSVN
  • gitSVN.debug
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • hydra
  • hydra.doc
  • kdePackages.kdev-php
  • kdePackages.kdev-php.debug
  • kdePackages.kdev-php.dev
  • kdePackages.kdev-php.devtools
  • kdePackages.kdev-python
  • kdePackages.kdev-python.debug
  • kdePackages.kdev-python.dev
  • kdePackages.kdev-python.devtools
  • kdePackages.kdevelop
  • kdePackages.kdevelop.debug
  • kdePackages.kdevelop.dev
  • kdePackages.kdevelop.devtools
  • kdesvn
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • python312Packages.pysvn
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.pysvn
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • thcrap-steam-proton-wrapper
  • vcstool
  • vcstool.dist
  • wp4nix

x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.pysvn
  • python313Packages.pysvn
✅ 38 packages built:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.doc ,gitFull.doc)
  • gitFull
  • gitSVN
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • vcstool
  • vcstool.dist
  • wp4nix

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.pysvn
  • python313Packages.pysvn
✅ 38 packages built:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.doc ,gitFull.doc)
  • gitFull
  • gitSVN
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • vcstool
  • vcstool.dist
  • wp4nix

@paparodeo
Copy link
Contributor Author

@paparodeo pysvn seems to be broken now.

(accidentally approved, wanted to post a build result for both Darwin systems)

it was marked as broken in 2021 e3dbed8

@khaneliman khaneliman merged commit 2d58a40 into NixOS:master Dec 31, 2024
48 of 49 checks passed
@paparodeo paparodeo deleted the svnclient-swig3.0 branch December 31, 2024 03:36
@paparodeo
Copy link
Contributor Author

@paparodeo pysvn seems to be broken now.
(accidentally approved, wanted to post a build result for both Darwin systems)

it was marked as broken in 2021 e3dbed8

and still fails with the same error: line 1: g++: command not found. it might be fixable if someone cares but out of the scope of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: subversionClient on aarch64-darwin
3 participants