Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostty: remove references to sources correctly #369282

Merged
merged 1 commit into from
Dec 30, 2024
Merged

ghostty: remove references to sources correctly #369282

merged 1 commit into from
Dec 30, 2024

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Dec 30, 2024

This line was previously in preFixup where the wrapper wasn't applied yet.

Regression from #368726.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fpletz
ghostty: remove references to sources correctly
d28175a 
This line was previously in preFixup where the wrapper wasn't applied yet.
@fpletz fpletz requested a review from getchoo December 30, 2024 02:25
@fpletz fpletz mentioned this pull request Dec 30, 2024
Merged
13 tasks
@getchoo
Copy link
Member

getchoo commented Dec 30, 2024

@ofborg build ghostty ghostty.passthru.tests

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 30, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 30, 2024
@getchoo getchoo merged commit 43d4dd0 into NixOS:master Dec 30, 2024
28 of 30 checks passed
@fpletz fpletz deleted the pkgs/ghostty-fix-remove-references branch December 30, 2024 03:14
uncenter pushed a commit to uncenter/nixpkgs that referenced this pull request Dec 30, 2024
@fpletz @uncenter
ghostty: remove references to sources correctly (NixOS#369282)
e3ec9e2 
This line was previously in preFixup where the wrapper wasn't applied yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpletz @getchoo