sby: 0.47 -> 0.48 #369528
Merged
sby: 0.47 -> 0.48 #369528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its tag naming was changed the same as Yosys, so r-ryantm couldn't update it either. This also gets sby working with Yosys 0.48; I didn't notice it being broken in NixOS#368946 because I only ran `nixpkgs-review` on macOS where sby doesn't build due to broken dependencies anyway. Sorry!
|
|
You can additionally put the test programs in the correct input: diff --git a/pkgs/by-name/sb/sby/package.nix b/pkgs/by-name/sb/sby/package.nix
index ca9687a2e70d..28ee23e1947f 100644
--- a/pkgs/by-name/sb/sby/package.nix
+++ b/pkgs/by-name/sb/sby/package.nix
@@ -19,18 +19,21 @@ in
stdenv.mkDerivation rec {
pname = "sby";
- version = "0.47";
+ version = "0.48";
src = fetchFromGitHub {
owner = "YosysHQ";
repo = "sby";
- rev = "yosys-${version}";
- hash = "sha256-Il2pXw2doaoZrVme2p0dSUUa8dCQtJJrmYitn1MkTD4=";
+ rev = "v${version}";
+ hash = "sha256-icOlWutvajHMCi2YUIGU4v5S63YobXw4fYYUvPoSzo4=";
};
- nativeBuildInputs = [ bash ];
- buildInputs = [
+ nativeBuildInputs = [
+ bash
pythonEnv
+ ];
+
+ nativeCheckInputs = [
yosys
boolector
yices
@@ -40,7 +43,7 @@ stdenv.mkDerivation rec {
];
postPatch = ''
- patchShebangs docs/source/conf.py \
+ patchShebangs --build docs/source/conf.py \
docs/source/conf.diff \
tests/autotune/*.sh \
tests/keepgoing/*.sh \
The references patched in postPatch will still work. |
thoughtpolice
approved these changes
Dec 31, 2024
|
It would be nice to include the fixes mentioned by @FliegendeWurst but it's not absolutely mandatory. I can wait a bit until merging this to give you a chance to fix it. |
|
|
Seems like nixpkgs-review was working right this time lol |
wegank
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its tag naming was changed the same as Yosys, so r-ryantm couldn't update it either.
This also gets sby working with Yosys 0.48; I didn't notice it being broken in #368946 because I only ran
nixpkgs-reviewon macOS where sby doesn't build due to broken dependencies anyway. Sorry!Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.