-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orca-slicer: fix gcc14 #369729
base: master
Are you sure you want to change the base?
orca-slicer: fix gcc14 #369729
Conversation
7bc8b17
to
8b7ae03
Compare
Ok have fixe somes issues from GCC14 is done but have mesa issue : Full
|
Are your drivers from the same Nixpkgs revision as the package? |
You probably want to include SoftFever/OrcaSlicer#7884 instead of using Boost 1.80. |
6c90d27
to
2faf5f7
Compare
To make the package version compliant and ready for strictDeps (#178468): diff --git a/pkgs/by-name/or/orca-slicer/package.nix b/pkgs/by-name/or/orca-slicer/package.nix
index 1dcfc55254cd..d013f52b10df 100644
--- a/pkgs/by-name/or/orca-slicer/package.nix
+++ b/pkgs/by-name/or/orca-slicer/package.nix
@@ -56,12 +56,12 @@ let
in
stdenv.mkDerivation rec {
pname = "orca-slicer";
- version = "2f55dd7cfe3e3d2c41fdd73dddc31f1c5dcbdf83";
+ version = "2.2.0-unstable-2025-01-01";
src = fetchFromGitHub {
owner = "SoftFever";
repo = "OrcaSlicer";
- rev = version;
+ rev = "2f55dd7cfe3e3d2c41fdd73dddc31f1c5dcbdf83";
hash = "sha256-2JHGNVKLJ5aJlcS0KCdegrTmj80utT5sfKO6XlG9blg=";
};
@@ -69,6 +69,7 @@ stdenv.mkDerivation rec {
cmake
pkg-config
wrapGAppsHook3
+ wxGTK'
];
buildInputs = |
Now is running but the last issue is :
|
|
|
Hi, @Atemu Best Regards
|
Well yes, that isn't going to work. Mesa version needs to match. You could hack around this by building mesa.drivers from this same revision and |
@GaetanLepage those are nitpicks/personal preference. Please mark them as such and don't block on them. |
c5e28d7
to
3256373
Compare
Well, I would argue that some of them are leaning towards consensual style. For instance, using Nevertheless, I also acknowledge that I tend to nit-picking too much. Thank you for your feedback. |
There is no such consensual style. That'd require an RFC as that'd be a broader community decision. We have that for formatting now but not for which patterns to use in derivations. Unless there is a very good technical reason (tag or finalAttrs do not reach this bar), you're free to choose any solution. Of course you as a reviewer can make the author aware of the existence of such patterns but you shouldn't insist on them until explicit community consensus exists.
It's being migrated because it's seen as an obvious improvement over the
Nitpicks are fine to make but their purpose should be information, not gatekeeping IMHO. You should explicitly mark them as such and not require them to be followed. When I only have nitpicks or even some minor non-nickpick requests I usually even signal approval to make it clear that following these is optional. |
Understood, thanks for sharing your point of view. |
f2f275b
to
9f295ed
Compare
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.