nixos/kmonad: add new option enableHardening #370437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
jian-lin
force-pushed
the
pr/kmonad-optional-hardening
branch
from
6899906 to
406935a
Compare
Before ```console $ systemd-analyze security kmonad-foo.service | tail -n 1 → Overall exposure level for kmonad-foo.service: 8.2 EXPOSED 🙁 ``` After ```console $ systemd-analyze security kmonad-foo.service | tail -n 1 → Overall exposure level for kmonad-foo.service: 0.4 SAFE 😀 ```
jian-lin
force-pushed
the
pr/kmonad-optional-hardening
branch
from
406935a to
37e6624
Compare
jian-lin
commented
Jan 3, 2025
| @@ -41,6 +41,19 @@ let | |||
| ''; | |||
| }; | |||
|
|
|||
| enableHardening = lib.mkOption { | |||
| type = lib.types.bool; | |||
| default = true; | |||
There was a problem hiding this comment.
Do you think enabling hardening is a good idea even if hardening may make some shell commands fail?
There was a problem hiding this comment.
I think it makes sense to have these options by default. For people that want to use cmd-button, they can disable this and add the options that are compatible with their macros themselves.
I will test it on my system and come back to you.
r-vdp
approved these changes
Jan 5, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.