bazel_{5,6,7}: use new apple sdk pattern #370672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 0
nix-owners
bot
requested review from
aherrmann,
avdv,
groodt,
mboes,
olebedev,
uri-canva and
ylecornec
13 tasks
|
|
Oh, how bad is that... |
|
|
For the last two commits, affected packages have been failing since long: https://hydra.nixos.org/job/nixpkgs/trunk/python312Packages.keras.aarch64-darwin I'll stop trying to fix more packages on Darwin, it's like pulling in an infinite number of irrelevant package patches. There's no rebuild on Linux anyway. |
|
|
Emmm, bazel builds well for me on x86_64-darwin. But anyway, there aren't many rebuilds there. Thanks for the nixpkgs-review. |
|
Thanks for fixing those. Darwin failures are indeed annoying. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes build failures on master: https://hydra.nixos.org/eval/1810825?filter=bazel&compare=1810818&full=#tabs-still-fail
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.